From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andy@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] gpio: ixp4xx: Handle clock output on pin 14 and 15
Date: Thu, 21 Sep 2023 14:34:02 +0200 [thread overview]
Message-ID: <CACRpkdadMCXyWYycMHZ0m7ZscTayJs=378e8DPJDkEEyTOeLUA@mail.gmail.com> (raw)
In-Reply-To: <ZQwngrU9fxdSGSKs@smile.fi.intel.com>
On Thu, Sep 21, 2023 at 1:23 PM Andy Shevchenko <andy@kernel.org> wrote:
> Maybe
>
> if (...)
> val = 0;
> else
> val = readl();
>
> ?
Neat, I'll do this!
> > + /*
> > + * Enable clock outputs with default timings of requested clock.
> > + * If you need control over TC and DC, add these to the device
> > + * tree bindings and use them here.
> > + */
>
> Shouldn't this be integrated into PPS subsystem?
PPS is for GPS, we *could* integrate it into the clk subsystem (with
configuration cells and all hoopla) but as I state in the cover letter
I think it becomes overengineered for this legacy system, there are
no users or benefit of that added complexity as compared to these
few-liners.
Yours,
Linus Walleij
prev parent reply other threads:[~2023-09-21 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 22:23 [PATCH 0/2] gpio: ixp4xx: Handle external clock output Linus Walleij
2023-09-20 22:23 ` [PATCH 1/2] gpio: Rewrite IXP4xx GPIO bindings in schema Linus Walleij
2023-09-21 18:44 ` Rob Herring
2023-09-20 22:23 ` [PATCH 2/2] gpio: ixp4xx: Handle clock output on pin 14 and 15 Linus Walleij
2023-09-21 11:22 ` Andy Shevchenko
2023-09-21 12:34 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdadMCXyWYycMHZ0m7ZscTayJs=378e8DPJDkEEyTOeLUA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kaloz@openwrt.org \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).