[PATCH 0/2] RK3588 GPIO Support

[PATCH 0/2] RK3588 GPIO Support

[Sebastian Reichel]

This has been part of a bigger patchset adding basic rk3588 support.
Since that gets more and more out of hand, I'm now sending patches
for each subsystem as individual patchset. Previou patchet:

https://lore.kernel.org/all/20220504213251.264819-1-sebastian.reichel@collabora.com/

Changes:
 * None (except for collecting Acks)

-- Sebastian

Jianqun Xu (1):
  gpio: rockchip: add support for rk3588

Sebastian Reichel (1):
  dt-bindings: gpio: rockchip: add gpio-ranges

 Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
 drivers/gpio/gpio-rockchip.c                                   | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.35.1

[PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges

[Sebastian Reichel]

Allow usage of gpio-ranges with the rockchip gpio controller. The driver
already had support for this since it has been added to the mainline kernel
in the first place.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
index d4e42c2b995b..affd823c881d 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
@@ -27,6 +27,8 @@ properties:
       - description: APB interface clock source
       - description: GPIO debounce reference clock source
 
+  gpio-ranges: true
+
   gpio-controller: true
 
   gpio-line-names: true
-- 
2.35.1

Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges

[Heiko Stuebner]

Am Donnerstag, 23. Juni 2022, 18:08:00 CEST schrieb Sebastian Reichel:
> Allow usage of gpio-ranges with the rockchip gpio controller. The driver
> already had support for this since it has been added to the mainline kernel
> in the first place.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add gpio-ranges

[Linus Walleij]

On Thu, Jun 23, 2022 at 6:08 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:

> Allow usage of gpio-ranges with the rockchip gpio controller. The driver
> already had support for this since it has been added to the mainline kernel
> in the first place.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH 2/2] gpio: rockchip: add support for rk3588

[Sebastian Reichel]

From: Jianqun Xu <jay.xu@rock-chips.com>

Add V2.1 rockchip gpio controller type, which is part of the
RK3588 SoC.

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 drivers/gpio/gpio-rockchip.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index e342a6dc4c6c..f91e876fd969 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -27,6 +27,7 @@
 
 #define GPIO_TYPE_V1		(0)           /* GPIO Version ID reserved */
 #define GPIO_TYPE_V2		(0x01000C2B)  /* GPIO Version ID 0x01000C2B */
+#define GPIO_TYPE_V2_1		(0x0101157C)  /* GPIO Version ID 0x0101157C */
 
 static const struct rockchip_gpio_regs gpio_regs_v1 = {
 	.port_dr = 0x00,
@@ -664,7 +665,7 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank)
 	id = readl(bank->reg_base + gpio_regs_v2.version_id);
 
 	/* If not gpio v2, that is default to v1. */
-	if (id == GPIO_TYPE_V2) {
+	if (id == GPIO_TYPE_V2 || id == GPIO_TYPE_V2_1) {
 		bank->gpio_regs = &gpio_regs_v2;
 		bank->gpio_type = GPIO_TYPE_V2;
 		bank->db_clk = of_clk_get(bank->of_node, 1);
-- 
2.35.1

Re: [PATCH 2/2] gpio: rockchip: add support for rk3588

[Heiko Stuebner]

Am Donnerstag, 23. Juni 2022, 18:08:01 CEST schrieb Sebastian Reichel:
> From: Jianqun Xu <jay.xu@rock-chips.com>
> 
> Add V2.1 rockchip gpio controller type, which is part of the
> RK3588 SoC.
> 
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 0/2] RK3588 GPIO Support

[Bartosz Golaszewski]

On Thu, Jun 23, 2022 at 6:08 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> This has been part of a bigger patchset adding basic rk3588 support.
> Since that gets more and more out of hand, I'm now sending patches
> for each subsystem as individual patchset. Previou patchet:
>
> https://lore.kernel.org/all/20220504213251.264819-1-sebastian.reichel@collabora.com/
>
> Changes:
>  * None (except for collecting Acks)
>
> -- Sebastian
>
> Jianqun Xu (1):
>   gpio: rockchip: add support for rk3588
>
> Sebastian Reichel (1):
>   dt-bindings: gpio: rockchip: add gpio-ranges
>
>  Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 2 ++
>  drivers/gpio/gpio-rockchip.c                                   | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 2.35.1
>

Both applied, thanks!

Bart