From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver Date: Fri, 15 Feb 2013 20:56:42 +0100 Message-ID: References: <1360778532-7480-1-git-send-email-dianders@chromium.org> <511BFF77.2090202@wwwdotorg.org> <511C32B5.20600@wwwdotorg.org> <20130215102420.GA22283@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130215102420.GA22283-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Mark Brown Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Kurtz , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren , Wolfram Sang , Ben Dooks , u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Guenter Roeck , Grant Grundler , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Jean Delvare , Alexandre Courbot , "Ben Dooks (embedded platforms)" , Girish Shivananjappa , "bhushan.r" , Naveen Krishna Chatradhi , "sreekumar.c" , Peter Korsgaard , Yuvaraj Kumar List-Id: devicetree@vger.kernel.org On Fri, Feb 15, 2013 at 11:24 AM, Mark Brown wrote: > On Thu, Feb 14, 2013 at 01:40:49PM -0800, Doug Anderson wrote: >> On Wed, Feb 13, 2013 at 4:54 PM, Doug Anderson wrote: > >> ...but when I moved to module_platform_driver() then things still broke. > >> [ 1.510000] platform-lcd supply lcd_vdd not found, using dummy regulator > >> I was sorta hoping that there would be some magic where >> regulator_get() would find the device tree node for the regulator and >> then resolve the chain. ...but maybe that's a pipe dream. > > You shouldn't have dummy regulators enabled at all, that'll break a > bunch of stuff including dependency resolution. They're a crutch to > help get things booting not something you should be using in production. > If they're not enabled regulator_get() will defer the probe. Hm, totally unrelated but Mark, should we consider marking the kernel tainted when the dummy regulators are in use? (And likewise for the dummy pinctrl I guess.) We could use some TAINT_INCONSISTENT_RESOURCES or something. I was thinking it could help to draw attention to resolving the platforms that stick dummy stuff in them and never get rid of it. But maybe this would be too rude? Yours, Linus Walleij