From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A291828D8F2 for ; Sat, 12 Jul 2025 19:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752348432; cv=none; b=Fw3bgpPJuAYWOPbHtpcc/ZRZ2l+YqNsZr4KIphrBDzbg6P9MZPHVVnzAavvkVsObN0E0WYVJ8p7wXOXTr025LSaUtJDYFzP4+IC2r6ObWpAoMy7ovZMWdGK5RoahsuVGPukLoOhI4OrbU7eLCANPMGGseU4Eg6W4jGDxXvQH+Q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752348432; c=relaxed/simple; bh=/hOKuusE5jMFtwzQjB1VDvpOrtRiFiTDNJiNJFK2Dmk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DGyQRM6tJpzXe4y7IfcmfSEh2uwvMr4O43EYOtjASRVaCW6HeQVr91uncrpJ+4AZ6QAu906o9PZ3/h/CgIXWZIErf/eDudE0YeWct2/WowsKTHLtaBgaHrKzAVqt5wlNOz3pVJZhqoVtBsKUOzbeRuwkk8/MIBC8jqjAaPT7YbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WhaAgGSX; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WhaAgGSX" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-32b561a861fso27254701fa.0 for ; Sat, 12 Jul 2025 12:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752348429; x=1752953229; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YmdrDokSvSEbkPXVz0WTUYECUUDrY3dIue4l79myHLA=; b=WhaAgGSXAZ2GkhcFDEsP6qj+RKcZn8+l/TjHOEB0rc5PFabu3pbbhJKkKcGNOjN/XS x58mToAJHF0fTCi79Km1iUhMdQ+WUraWoGTrV6zDdtnYEbpGEWWOFfyT6KxCX6fc0kJj rX/Et2DH8vPoHqnQNHUQf8PRakWhKpNMuI0W5PH3cU4JgL5REt1UEcWVvEgPMZyS6E6n Msv1LhhXTSFkn3sCAJ0GXDhVH2/g0xUEaEFG2qcVjCBhSEe1a3qQ08SrV6vv0obAIEvt J9SY5jzLcS1zzrg+9ZvcX6/Vq9e5o8fJoRMTDoldYcsHjtlBjezR2yapWFfJHIc4wUtH a2rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752348429; x=1752953229; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YmdrDokSvSEbkPXVz0WTUYECUUDrY3dIue4l79myHLA=; b=QCK+wjK3JL3UrhYmaumkZbR5HoiShg6t94j+x2B9G2LLmxouQ43s9uksNrwrz+iH6W PboRMb0n5imI/bUB6TSbKTPq0eKuVtpCczmWVIznwpqodsoTSNNWh148sFXZjW/ZM+jH hu/SySoY8noXtmpg05j80Y/TMSV+Wssn/VXZJLaJWMBhNQYQgYLfOL8qxenwVB2aNW4F rAi+SNI83I2LdowIVWlB2Waf7Zi8nX7c5l7Dw0paW+31Nbb7PI+0rTQZrOzbP3VfkrYJ zzLlrCxMS8P/IPFDaWamhkHPu5pmUXcsma8EFq/tOT1BPgprrxzW07nttY0bpQZp38bQ Y8Sg== X-Forwarded-Encrypted: i=1; AJvYcCVaTGo1gZLJDAtMswiiLNiAwfiTI6wFMemfUTdrMFaghIRzwhkcfnDcWOqcGjsWAKis8/uuEQ0J2yv6@vger.kernel.org X-Gm-Message-State: AOJu0YwADbMwPSy3qDApQ0JvSn2xlDkPOC8JvDP94CLxcSliVZPWmSlY PxWnhKBB1HETaxthDdAHMEJeNAc6oHVAEwK1jGUfOKN8OKVLFfYW8rbHjERa3ygklKjFeIVJe9K zsL7D8tYSGGcT/sRxHFyxhiPG6ScAGe8ClNGvvH5oYg== X-Gm-Gg: ASbGncvFc1tv3yqSd0a3oJ5Aoa25noVroaVSv1vSO+58TY27NewsshCLA46PTKn2VdV 6AsL/9KqUkbyyAC4AYEA+85VhzUHFv21VuVBrLyTGLDe/EECfZsc3+bUF8UoM2zW7gukNbNVksC cjxUcuviW1AKtGHKPQDotDrwV8oYeH016827j6ZrvFSwiTtox3WkDdLNfG9dw/DDx2+3LRSWyWf Y36T/g= X-Google-Smtp-Source: AGHT+IEg/39vWPjh633ZUj8UqZLuNkeQ4zJb+DeEXqhdOGqkb2UzJv4loDelR2kMaTSHX23IkdKGCBQxVkP3ySeashA= X-Received: by 2002:a05:651c:4ca:b0:32b:755e:6cd7 with SMTP id 38308e7fff4ca-3305509f9c8mr19310751fa.32.1752348428638; Sat, 12 Jul 2025 12:27:08 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250710002047.1573841-1-ksk4725@coasia.com> In-Reply-To: <20250710002047.1573841-1-ksk4725@coasia.com> From: Linus Walleij Date: Sat, 12 Jul 2025 21:26:57 +0200 X-Gm-Features: Ac12FXwfRBs5js5oSquCaRb4DKz10a2pVgF5CqiS_5Na7OWkjOlWh-jR8X6bLJY Message-ID: Subject: Re: [PATCH 00/16] Add support for the Axis ARTPEC-8 SoC To: ksk4725@coasia.com Cc: Jesper Nilsson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Tomasz Figa , Catalin Marinas , Will Deacon , Arnd Bergmann , kenkim , Jongshin Park , GunWoo Kim , HaGyeong Kim , GyoungBo Min , SungMin Park , Pankaj Dubey , Shradha Todi , Ravi Patel , Inbaraj E , Swathi K S , Hrishikesh , Dongjin Yang , Sang Min Kim , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, soc@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Hakyeong, thanks for your patch! On Thu, Jul 10, 2025 at 2:20=E2=80=AFAM wrote: > Add basic support for the Axis ARTPEC-8 SoC. > This SoC contains four Cortex-A53 CPUs and other several IPs. > > Patches 1 to 10 provide the support for the clock controller, > which is similar to other Samsung SoCs. > > The remaining patches provide pinctrl support and > initial device tree support. > > Hakyeong Kim (9): > dt-bindings: clock: Add ARTPEC-8 CMU bindings > clk: samsung: Add clock PLL support for ARTPEC-8 SoC > clk: samsung: artpec-8: Add initial clock support > clk: samsung: artpec-8: Add clock support for CMU_CMU block > clk: samsung: artpec-8: Add clock support for CMU_BUS block > clk: samsung: artpec-8: Add clock support for CMU_CORE block > clk: samsung: artpec-8: Add clock support for CMU_CPUCL block > clk: samsung: artpec-8: Add clock support for CMU_FSYS block > clk: samsung: artpec-8: Add clock support for CMU_PERI block Out of the 9 patches there are 7 patches related to "CMU" without any explanation or even expansion of this acronym. Camera Management Unit? I think I'm not supposed to guess. Is is an Axis-custom piece of hardware? (Would make sense.) Please expand this acronym and state clearly that (if this is a correct assumption) that you are not supplying any bindings and even less a driver for the "CMU" thing, just the clocks. (That's fine the actual CMU can come later, but it should be clear *what* it is.) Yours, Linus Walleij