From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: question about drivers/pinctrl/pinctrl-at91.c Date: Tue, 11 Dec 2012 10:08:57 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: plagnioj@jcrosoft.com, grant.likely@secretlab.ca, rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Tue, Dec 11, 2012 at 10:04 AM, Julia Lawall wrote: > On Tue, 11 Dec 2012, Linus Walleij wrote: >> I was under the impression that if you exit the probe function >> with a negative value anything allocated with devm_* was freed >> immediately, that is atleast how it's described in >> Documentation/driver-model/devres.txt >> atleast that seems to be the intetion with the whole thing. > > That is true, but I wasn't sure taht this function was part of the probe > function. Its only reference is in: > > static struct pinctrl_ops at91_pctrl_ops = { > .get_groups_count = at91_get_groups_count, > .get_group_name = at91_get_group_name, > .get_group_pins = at91_get_group_pins, > .pin_dbg_show = at91_pin_dbg_show, > .dt_node_to_map = at91_dt_node_to_map, > .dt_free_map = at91_dt_free_map, > }; > > Working backwards, one possible call site is pinctrl_get, which is an > exported function. Is it safe to assume that it will always be called > from within a probe function? Aha sorry I got it all backwards :-( Well, yes in that case it's devm_kfree() for sure. Thanks! Yours, Linus Walleij