From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF1F6C43457 for ; Thu, 8 Oct 2020 20:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 801B422240 for ; Thu, 8 Oct 2020 20:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YoiXBLYa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730753AbgJHUy0 (ORCPT ); Thu, 8 Oct 2020 16:54:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730731AbgJHUyZ (ORCPT ); Thu, 8 Oct 2020 16:54:25 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66425C0613D3 for ; Thu, 8 Oct 2020 13:54:25 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id a9so8140117lfc.7 for ; Thu, 08 Oct 2020 13:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tocO/B9Lq6+1kVJFUNhSCxjxnRpjafNIdcN4JRNBVbc=; b=YoiXBLYaxbs0qCVBRDnMH27sFMKBPT5ra2QPLTUzuzpkCRDid+wTU6iVsny55UyX+z ZSwVBRBUgbSb+p2PA7gjjgwvp42yXzz7v/C5ADQpzZveA7GHjZtKBaRQttK/Q2RZNYy5 aJ15KMFFzwBqNJzmYvat5bZCmRhbrfkFDl+PB6T+MWyKEh3k1JL0mBRnMfAkRNnmKWZ0 CAXplWyqxfYga8bbMW54N/Um8CEACrqaH2k1qvUc70gGyhXOgZmgo1uflLsUJVzbSNH9 Jl+HukaQt0GcYCsSxUq30pCijnPFjCZzqiavpJge8g6AIxRSxYz7XxX2dJJdHC/2xqgn WNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tocO/B9Lq6+1kVJFUNhSCxjxnRpjafNIdcN4JRNBVbc=; b=lcNgdS/d97VCugu8zAzPv14inol8Lfo11OEjZAa6z+e6BH1ObxcZyJsew8sxiZ493B CuSqBGVTEGer323or1lfa9HGJoZ7UuG0OxiDJd8FOi3WsgId7SZi25WMC0Dwg41/tgkl /D2O7/yElfsdc4tG37fV/eXrKEH+4AUm+a6L4T21/bOp4w0LRXfiyTsN+U/b5dlFDhcx USB3yEhGB9Oo4T8nbnhbDWVTsxxsmjotFsx86Q7+kH0xjclJvGuCBbIl+4AQ9Nghz+AL zMAzfIWSIesD3HGiEJxRGpRZLGMseiAGuvNzb8Pk1jiNW7MR4b7YGg/GZ1qsiseCfw0S uBEw== X-Gm-Message-State: AOAM53230J92zGSSrf1GHpayF8I/w5uw2l4uBTxUiBynst6YJVV9gkHb SL84NlGiynDUKijxQ645r+4oxg+XWi1ILcECiihM/A== X-Google-Smtp-Source: ABdhPJxcWRYqQbXfXwqugkMw/o/Tb2QvJ1KChfARrTOjotSF8GKqXHAadrzMf4OTQL6OgJgT6Np7m8icj77pU9yHJo8= X-Received: by 2002:a19:824f:: with SMTP id e76mr1878046lfd.572.1602190463699; Thu, 08 Oct 2020 13:54:23 -0700 (PDT) MIME-Version: 1.0 References: <20201005160614.3749-1-ben.levinsky@xilinx.com> <20201005160614.3749-5-ben.levinsky@xilinx.com> In-Reply-To: From: Linus Walleij Date: Thu, 8 Oct 2020 22:54:12 +0200 Message-ID: Subject: Re: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings To: Ben Levinsky Cc: Catalin Marinas , Stefano Stabellini , "Ed T. Mooring" , "sunnyliangjy@gmail.com" , Punit Agrawal , Michal Simek , "michael.auchter@ni.com" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Mathieu Poirier , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 8, 2020 at 4:21 PM Ben Levinsky wrote: > As you said, this is just regular ARM TCM memory (as seen by the main AR= M64 cluster). > Yes I can add back the compatible string, though maybe just "tcm" or "xln= x,tcm" I mean that if it is an ARM standard feature it should be prefixed "arm," > That being said, we can change this around to couple the TCM bank nodes i= nto the R5 as we have In our present, internal implementation at > - https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetr= ee/bindings/remoteproc/xilinx%2Czynqmp-r5-remoteproc.txt > - https://github.com/Xilinx/linux-xlnx/blob/master/drivers/remoteproc/zyn= qmp_r5_remoteproc.c > the TCM nodes are coupled in the R5 but after some previous review on thi= s list, it was moved to have the TCM nodes decoupled from the R5 node > > I am not sure what you mean on the Arm64 handling of TCM memory. Via the = architecture of the SoC https://www.xilinx.com/support/documentation/user_g= uides/ug1085-zynq-ultrascale-trm.pdf I know that the A53 cluster can see th= e absolute addresses of the R5 cluster so the translation is *I think* done= as you describe with the CP15 instructions you listed. It seems like the TCM memories are von Neumann type (either can contain both code and data) which removes one of my worries. According to this data sheet they are also nothing ARM-provided but a Xilinx invention, and just happen to be hardcoded at the same address as TCM memories in ARM32, what a coincidence. So I take it this is the correct view and you can proceed like this, sorry for the fuzz. Yours, Linus Walleij