From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpio/serial: revert "linux,first-pin" property handling Date: Wed, 12 Jul 2017 11:30:12 +0200 Message-ID: References: <20170710140902.21935-1-linus.walleij@linaro.org> <5310fa81-dc0e-75b1-05fb-2ec9b558f867@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <5310fa81-dc0e-75b1-05fb-2ec9b558f867@siemens.com> Sender: linux-gpio-owner@vger.kernel.org To: Jan Kiszka Cc: "linux-gpio@vger.kernel.org" , Andy Shevchenko , Greg Kroah-Hartman , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Tue, Jul 11, 2017 at 5:42 PM, Jan Kiszka wrote: > On 2017-07-10 16:23, Jan Kiszka wrote: >> On 2017-07-10 16:09, Linus Walleij wrote: >>> This is not a legal device tree property, because its binding has >>> not been reviewed and approved, nor does it exist in any device >>> tree binding document. >>> >>> It is further wrong, because it is added to the GPIO offset which >>> is by definition controller-local. > > BTW, I don't get this second statement. The parameter passed in is > controlling which pin of the GPIO device can be controlled by the driver > at all. And that's also a very private interface between 8250_exar and > gpio-exar: the former tells the latter which pins are physically > available to drive, because the former operates the others already. Then it seems like the big confusion here is the "linux,*" prefix in the DT binding. We only use that for information which is necessary evil Linux-specific stuff. What you are talking about should be hardware-and-vendor specific info and prefixed "exar,*". Can you propose a patch simply changing the binding and try to get the DT maintainers ACK on it? Yours, Linus Walleij