From: Linus Walleij <linus.walleij@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: sx150x: Update OF configuration
Date: Sat, 18 Jun 2016 11:02:02 +0200 [thread overview]
Message-ID: <CACRpkdbDMo=cV5bmcWNbeHU+c-AyokpaFNNZJF4UPY+twDX8bw@mail.gmail.com> (raw)
In-Reply-To: <1466157063-10955-1-git-send-email-narmstrong@baylibre.com>
On Fri, Jun 17, 2016 at 11:51 AM, Neil Armstrong
<narmstrong@baylibre.com> wrote:
> In case of OF probing, the driver fails to initialize :
> - gpio_chip.base must be -1
> - irq_summary must be either -1 or valid
> - There is no way to use the other configurations
>
> Add OF parsing function to complete the HW configuration, make
> OF configuration dynamic instead of static with #defines and
> update the DT bindings.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
As you can see from the result of the build robot, the removal
of #ifdef CONFIG_OF_GPIO does not play well with non-DT
configurarions.
You need to figure something out here so that it builds for
both.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-06-18 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 9:51 [PATCH] gpio: sx150x: Update OF configuration Neil Armstrong
2016-06-17 11:11 ` kbuild test robot
2016-06-18 9:02 ` Linus Walleij [this message]
2016-06-20 9:03 ` Neil Armstrong
[not found] ` <1466157063-10955-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-20 15:57 ` Rob Herring
2016-06-23 8:08 ` Linus Walleij
2016-06-23 8:18 ` Neil Armstrong
2016-06-23 9:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbDMo=cV5bmcWNbeHU+c-AyokpaFNNZJF4UPY+twDX8bw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).