From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: Re: [PATCH 01/11] pinctrl: sunxi: create irq/pin mapping during init Date: Wed, 28 May 2014 10:53:19 +0200 Message-ID: References: <1401090486-4414-1-git-send-email-hdegoede@redhat.com> <1401090486-4414-2-git-send-email-hdegoede@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: linux-sunxi , devicetree , Ulf Hansson , linux-wireless , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chris Ball , "John W. Linville" , Hans de Goede , Arend van Spriel , Maxime Ripard , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, May 27, 2014 at 4:21 PM, Chen-Yu Tsai wrote: > On Tue, May 27, 2014 at 10:11 PM, Linus Walleij >> I tried to hack the sunxi driver to even use the gpiolib >> irqchip helpers but exactly this complex map thing in >> ->irq_array[] git me stuck. If any of you guys could be so >> nice to take a stab at this (compare to other commits >> converting drivers to use gpiolibs irqchip helpers) then >> I'd be very happy. > > We still need to rework the whole irqchip stuff for sun6i/sun8i, > which have 1 parent interrupt per EINT capable pin bank. > > Earlier discussions with Maxime (on IRC IIRC) suggested moving this > over to gpiolib irqchip helpers might be more work than using our own > irqchip implementation, requiring 1 gpiochip per pin group? (not sure) OK then keep your current code. I do not intend to cover all cases in the world with these helpers, just the simple cases. Complex hardware merits complex code. Yours, Linus Walleij