From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DAFC433FE for ; Fri, 18 Nov 2022 21:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiKRV0k (ORCPT ); Fri, 18 Nov 2022 16:26:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiKRV0j (ORCPT ); Fri, 18 Nov 2022 16:26:39 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3224FA2884 for ; Fri, 18 Nov 2022 13:26:35 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id z20so7391330edc.13 for ; Fri, 18 Nov 2022 13:26:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gn19h91kD2DXtHLVTlmvX/z0+yNPKmW/7RO5Bbqf1MM=; b=FuGELQ46WHyMDr8mQpKAZjqb0l82MxhqlvgSAv6Po5f7yjBMJaIL42l7phMLc8R6Na SXmeZ6W6eSL7rQWunnHHmsZc/f9i/K0L5D28oi4xLPvx52ehylKA2MKq167XiG43QjjT k398LCs8w+zDm6A2gm+6GsyZoOnbm80rRM7MQxjN2tdNNYLLd/eQhXQTJXT8mInHxDdo zx4oPW+Ifl/+gVJD0MgQZ4YuiT3Lwzq/2z95lhiTVCHFivhzbYTn6kMen8x6aAqJu10a zeGnF4dOe2IfU3F0lRQONNWBK4Vxpf1eKGBUUQJdXVJBNiQtLW6v+GNYYePo5N9FToS0 UtKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gn19h91kD2DXtHLVTlmvX/z0+yNPKmW/7RO5Bbqf1MM=; b=stwwmuIe4nUZKfo0pVRKMAmMG0cVhMsLrrwEcEvnYHZA/ZPWDEtzyEOGI+klIGOdtJ xswahT8pFUDWhAVCLN7ACjnF5yDPWKnVMueexN+f8UyNPf94FR//KAFfCA4OoIlLIMPY Wh6JrZ3l0YuCvLh63AzQrS+1KKNVe4zCy4rJDf27QucEModWQE5XT9kh8G8fbFU0cKw8 CAP05/gx+SQhWN+eNsQFrtxrZhyn/c+0A0nHZ6PoRmJ4ZA1uMWOEKOtvmI7RhQZThxrQ iUt2KzUCy7mBhxNnhR6Dx4zTR6UNUbjtxuJJUg8QRn6jSTnBAArbwPi563Mrl3Qpqxne Iy+A== X-Gm-Message-State: ANoB5pk64ToAfTAuf564t2nE8OSeGB6Qp7kGlmeaKswPob9mKZyIxT/n ioCPDa6KJ/VqT1QgSRqpJD8XebA4z7JUYoL+ZW7MZw== X-Google-Smtp-Source: AA0mqf7/jfSfmCMp1R3z90KPsI7aEquK2Hg1zTkkjjR73PB27eXwJMYj8xkB+a9dyVksrMBxxq9IE8bZY63uCH8TSOA= X-Received: by 2002:a05:6402:c0b:b0:463:a83c:e0af with SMTP id co11-20020a0564020c0b00b00463a83ce0afmr7463177edb.158.1668806793738; Fri, 18 Nov 2022 13:26:33 -0800 (PST) MIME-Version: 1.0 References: <20221117080916.411766-1-cosmin.tanislav@analog.com> <20221117080916.411766-3-cosmin.tanislav@analog.com> In-Reply-To: <20221117080916.411766-3-cosmin.tanislav@analog.com> From: Linus Walleij Date: Fri, 18 Nov 2022 22:26:21 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] iio: addac: add AD74115 driver To: Cosmin Tanislav Cc: Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , William Breathitt Gray , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 17, 2022 at 9:09 AM Cosmin Tanislav wrote: > The AD74115H is a single-channel, software-configurable, input and > output device for industrial control applications. The AD74115H > provides a wide range of use cases, integrated on a single chip. > > These use cases include analog output, analog input, digital output, > digital input, resistance temperature detector (RTD), and thermocouple > measurement capability. The AD74115H also has an integrated HART modem. > > A serial peripheral interface (SPI) is used to handle all communications > to the device, including communications with the HART modem. The digital > input and digital outputs can be accessed via the SPI or the > general-purpose input and output (GPIO) pins to support higher > speed data rates. > > The device features a 16-bit, sigma-delta analog-to-digital converter > (ADC) and a 14-bit digital-to-analog converter (DAC). > The AD74115H contains a high accuracy 2.5 V on-chip reference that can > be used as the DAC and ADC reference. > > Signed-off-by: Cosmin Tanislav (...) > +config AD74115 > + tristate "Analog Devices AD74115H driver" > + depends on GPIOLIB && SPI I think you can technically just select GPIOLIB making it easier for users, but that's up to you and definitely fine like this too. Reviewed-by: Linus Walleij Yours, Linus Walleij