* [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size
@ 2022-08-09 21:45 Rob Herring
2022-08-10 6:19 ` Krzysztof Kozlowski
2022-08-22 11:07 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2022-08-09 21:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Krzysztof Kozlowski, Sricharan R
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells.
The qcom,ipq6018-pinctrl example is a cell short:
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml
Signed-off-by: Rob Herring <robh@kernel.org>
---
Please ack and I can send to Linus before rc1.
---
.../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index b83c7f476e19..931e5c190ead 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -144,7 +144,7 @@ examples:
#interrupt-cells = <2>;
gpio-controller;
#gpio-cells = <2>;
- gpio-ranges = <&tlmm 0 80>;
+ gpio-ranges = <&tlmm 0 0 80>;
serial3-pinmux {
pins = "gpio44", "gpio45";
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size
2022-08-09 21:45 [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size Rob Herring
@ 2022-08-10 6:19 ` Krzysztof Kozlowski
2022-08-22 11:07 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-10 6:19 UTC (permalink / raw)
To: Rob Herring, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Krzysztof Kozlowski, Sricharan R
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 10/08/2022 00:45, Rob Herring wrote:
> 'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells.
> The qcom,ipq6018-pinctrl example is a cell short:
>
> Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
> From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please ack and I can send to Linus before rc1.
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size
2022-08-09 21:45 [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size Rob Herring
2022-08-10 6:19 ` Krzysztof Kozlowski
@ 2022-08-22 11:07 ` Linus Walleij
2022-08-25 19:32 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2022-08-22 11:07 UTC (permalink / raw)
To: Rob Herring
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Sricharan R, linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Tue, Aug 9, 2022 at 11:46 PM Rob Herring <robh@kernel.org> wrote:
> 'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells.
> The qcom,ipq6018-pinctrl example is a cell short:
>
> Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
> From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please ack and I can send to Linus before rc1.
Sorry for delay, was on vacation :/
Acked-by: Linus Walleij <linus.walleij@linaro.org>
I think as binding maintainer you can just submit this kind of smaller stuff
without any subsystem consent, if you have it acked by Krzysztof, even more so.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size
2022-08-22 11:07 ` Linus Walleij
@ 2022-08-25 19:32 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-08-25 19:32 UTC (permalink / raw)
To: Linus Walleij
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Sricharan R, linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Mon, Aug 22, 2022 at 01:07:48PM +0200, Linus Walleij wrote:
> On Tue, Aug 9, 2022 at 11:46 PM Rob Herring <robh@kernel.org> wrote:
>
> > 'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells.
> > The qcom,ipq6018-pinctrl example is a cell short:
> >
> > Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
> > From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Please ack and I can send to Linus before rc1.
>
> Sorry for delay, was on vacation :/
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I think as binding maintainer you can just submit this kind of smaller stuff
> without any subsystem consent, if you have it acked by Krzysztof, even more so.
Don't worry, I did. It is in rc1.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-25 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-09 21:45 [PATCH] dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size Rob Herring
2022-08-10 6:19 ` Krzysztof Kozlowski
2022-08-22 11:07 ` Linus Walleij
2022-08-25 19:32 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).