From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14206C2D0E4 for ; Wed, 18 Nov 2020 01:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A753224682 for ; Wed, 18 Nov 2020 01:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bh+8rQxw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727876AbgKRBRX (ORCPT ); Tue, 17 Nov 2020 20:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbgKRBRX (ORCPT ); Tue, 17 Nov 2020 20:17:23 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91256C061A48 for ; Tue, 17 Nov 2020 17:17:22 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id w142so549345lff.8 for ; Tue, 17 Nov 2020 17:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=upNhDSD7uK2ZOVQ0hHkzhR+LnuCA5mLVwy01zUvUhgY=; b=bh+8rQxwa7EjqGdcGJ0qNVsUM0Efy0UbTffNihX5hvdZWSCg13yXcuLVT/XQ+mL3y8 j3YsVmlBs2K2YkpaHT7okR68fq7dIIoLfLJFfUod/C+v6O0fHrxUPaYU6WvirJjsdGaT m5iuhQ0cBW3zH1BevrETby2ATSldsXill6yhSradv2bCdNneCQdasMPdNavDdsDRXbwH o5i39TSLtvB1PYLKz4dhv38Xvz8w3kyQcVJa+hDXFJpeGC1uRk55rxjd2WQ8Xb1bPqAt k8eetWzgpY6smlLohuJC67AP4sHcQEju41rmUl+whR00O9X00ObqbUmEUq57rqPR26i+ TwMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=upNhDSD7uK2ZOVQ0hHkzhR+LnuCA5mLVwy01zUvUhgY=; b=nXY3mgcvoCrxee89W+bvXtlOZbfT/cvydSGOw13G4y43RMjpPU2MZEYCaY8xuSxOES RLFi2+gmhhY6xI2w7TbyZmVI1x0uRfJOuSFC8KSBOHPWIepX/fa6vsLiAyjGMCpn0grA zJKGjHeVAgoJKZ9ytAOqD0TE5QXCdPfCvhwMqgJ9wxBNTm/SdZ6zmN5WGF2r1+NLtWH4 t7qPQ7SI69XKWfeXioFC29OHuVnfscruMFCQjUUJc/l21onO6CwYkLnAS19M3QE9KA1l PecWG0qphzehZl1MjHFWSEqJDwmP/qtG/qlQ3+KhFJVfLpdqgIulh/z+L5aRk+oRl5tP D2LQ== X-Gm-Message-State: AOAM533fUaGNkASeJE+PA9e0gV7kASekXu/aiRLBiXhTb8FkYRQO8QwO GzL5TTmkqsl7ZCmR7HCxoSSS4bH2qMf/IkXgdBbzTw== X-Google-Smtp-Source: ABdhPJxFHQAIQRDKhTcuTDcK2nXR2ixM+rGNxNiVeK8ytP7bxNblPyvGZGafF5gPs+1iohaXMatPtKjbDdSfBnvUCG0= X-Received: by 2002:a19:546:: with SMTP id 67mr2520411lff.502.1605662241004; Tue, 17 Nov 2020 17:17:21 -0800 (PST) MIME-Version: 1.0 References: <20201117174845.28684-1-manivannan.sadhasivam@linaro.org> <20201117174845.28684-5-manivannan.sadhasivam@linaro.org> In-Reply-To: <20201117174845.28684-5-manivannan.sadhasivam@linaro.org> From: Linus Walleij Date: Wed, 18 Nov 2020 02:17:09 +0100 Message-ID: Subject: Re: [PATCH v2 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure To: Manivannan Sadhasivam Cc: =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Richard Weinberger , Vignesh R , Rob Herring , Bjorn Andersson , linux-mtd@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , MSM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Nov 17, 2020 at 6:49 PM Manivannan Sadhasivam wrote: > In the case of failure while parsing the partitions, the iterator should > be pre decremented by one before starting to free the memory allocated > by kstrdup(). Because in the failure case, kstrdup() will not succeed > and thus no memory will be allocated for the current iteration. > > Cc: Linus Walleij > Fixes: 1fca1f6abb38 ("mtd: afs: simplify partition parsing") > Signed-off-by: Manivannan Sadhasivam Good find! Reviewed-by: Linus Walleij Yours, Linus Walleij