From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [RFC PATCH 01/14] devres: Add devm_of_iomap() Date: Fri, 29 Jun 2018 11:14:47 +0200 Message-ID: References: <20180622043134.18238-1-benh@kernel.crashing.org> <20180622043134.18238-2-benh@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180622043134.18238-2-benh@kernel.crashing.org> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Herrenschmidt Cc: OpenBMC Maillist , linux-aspeed@lists.ozlabs.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Greg KH , Andrew Jeffery List-Id: devicetree@vger.kernel.org On Fri, Jun 22, 2018 at 6:31 AM Benjamin Herrenschmidt wrote: > There are still quite a few cases where a device might want > to get to a different node of the device-tree, obtain the > resources and map them. > > We have of_iomap() and of_io_request_and_map() but they both > have shortcomings, such as not returning the size of the > resource found (which can be useful) and not being "managed". > > This adds a devm_of_iomap() that provides all of these and > should probably replace uses of the above in most drivers. > > Signed-off-by: Benjamin Herrenschmidt Ugh I just feel I have seen homecooked solutions to this problem a few times :/ I wonder if it is easy to find these cases and replace them with this neat function... Thanks for doing this. Reviewed-by: Linus Walleij Yours, Linus Walleij