From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43629C433EF for ; Mon, 18 Jul 2022 10:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234107AbiGRKcn (ORCPT ); Mon, 18 Jul 2022 06:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234267AbiGRKcm (ORCPT ); Mon, 18 Jul 2022 06:32:42 -0400 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C0FB1D0E7 for ; Mon, 18 Jul 2022 03:32:41 -0700 (PDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-31e1ecea074so25364577b3.8 for ; Mon, 18 Jul 2022 03:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=64V5h6/X7Wjx5m1nkylh2H6thEd31QIKHGVSbZXsoNg=; b=y+Bb11Nn7lbZpi48Ys1bbGVZsZpdwxRUCE6emMk5fmECkUxx56FTwNuAh5XDq3miIl pY7a4VhUtbU08BIN9YWUY1ThRtAWZCBszC31Vfig9C+BKGNXS5sKs06yTIK9S5hax1im zbIyc5MS9NotXbFgCNPRBpMyNIZnGYfxOycR0t1OQiDyEGXYNY9tWn8hHx69KDuU8iYN 5CWvXp91eyy5P4HhQ3sBdoENDVtw5oKEgFnU+LxF2HrdY8m2LvgbWodLj89VlMaREDNq XK3MFOdT41xTlKuP4bEythSXGgYw0ASFGZpPAlvq51Z4C4o8UbIvgdbkqRQ+ORVDkNK5 Hs8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=64V5h6/X7Wjx5m1nkylh2H6thEd31QIKHGVSbZXsoNg=; b=6KsXAlOG5DFn1kuArUoesDBsxwbZY35b9xnQhbKA8mmRVOnWzM2i0iojS6dxdJewc1 79vnbLxtIGV6DxMToY2mSfVG+L75X7KwTyo/D2CVnekQ0FalG7QQX/jYeTNiMxOhIWYZ G87CNZSKhfoGAiMRRDQep+Fh0Vlai08bxLYtyQChlPVLLM+wIjgi50n+qu275WexZJ7t xxdA1KOwrtV1UDxaGuhHUjxoNvYuGiTyL+lfuTWlOWJMcSYFnYsbeVfya23FQqeb1B8x gOKuGUjhhL6YKO7xyGhXDx/Yy0/1I9HJ/R699Y3AfCq/sP8bsrgwiPQ3++onEwh1RX3K PQxQ== X-Gm-Message-State: AJIora+u79g2IH0Z8VO/aFae51oWI47ld5IGj1I7F2I8l09TXf/meZ40 6NkPDN+HgGhtSJCddC5m56dEKV6cvcv/VW+5haEOnw== X-Google-Smtp-Source: AGRyM1uO3lwXmKMJUHBOB5ohsirv0rbElHPlJvBvbUxHx2ntUT21qGZcSxbrFm6wLpSNCS8p96webSHut1HXQ33nOm8= X-Received: by 2002:a81:7341:0:b0:31c:c547:ce02 with SMTP id o62-20020a817341000000b0031cc547ce02mr29182404ywc.108.1658140360551; Mon, 18 Jul 2022 03:32:40 -0700 (PDT) MIME-Version: 1.0 References: <20220713131421.1527179-1-nuno.sa@analog.com> <20220713131421.1527179-4-nuno.sa@analog.com> In-Reply-To: <20220713131421.1527179-4-nuno.sa@analog.com> From: Linus Walleij Date: Mon, 18 Jul 2022 12:32:29 +0200 Message-ID: Subject: Re: [PATCH 3/4] gpiolib: acpi: support bias pull disable To: =?UTF-8?B?TnVubyBTw6E=?= Cc: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Andy Shevchenko , Krzysztof Kozlowski , Bartosz Golaszewski , Frank Rowand , Mika Westerberg , Rob Herring Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 13, 2022 at 3:13 PM Nuno S=C3=A1 wrote: > On top of looking at PULL_UP and PULL_DOWN flags, also look at > PULL_DISABLE and set the appropriate GPIO flag. The GPIO core will then > pass down this to controllers that support it. > > Signed-off-by: Nuno S=C3=A1 Do we have a semantic check that PULLDOWN and PULLUP is not used in combination with NOPULL here? (We should also be checking that PULLDOWN and PULLUP are not used simultaneously but that is an unrelated thing.) Yours, Linus Walleij