From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3B0C636CA for ; Sun, 18 Jul 2021 00:17:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B28906115A for ; Sun, 18 Jul 2021 00:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231840AbhGRAUF (ORCPT ); Sat, 17 Jul 2021 20:20:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbhGRAUE (ORCPT ); Sat, 17 Jul 2021 20:20:04 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A225C061762 for ; Sat, 17 Jul 2021 17:17:06 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id s17so8981244ljo.12 for ; Sat, 17 Jul 2021 17:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X1WDN9LkkfTLodn/7AZmvdlWK3elCwMaUY4+s15zcjs=; b=lr/rWTTelnW7nH05zdzy9FmUTLjtt9x/tUlCN50zyyz+UyWy1fPUrp4MBwEazKLI1X 2tI09g2FvGKVdBNeR3iA0kePNjlxn4uF99kvRlbRpGmJBtM2bXfqPCvnMsV4fZEDXgOB cfwfCTZpRJpP8XCfwPBB5HLe6EFbcUx+r6SV3aYbkgX+R7j54g2UEufmNHwppKl+Dy60 eOF4MHP2iIoOLUblsBzMt0mEgLB7yhdJNOCfiHkbgnmudCLvzyCDPAW4uBSYjhD/V0iB QzT5UmxJpzVt0uhk/TARoTkXEq7y4rI/1NwAj9vsXfO4oc8lvVdfu0NPKzeKeoGF+Sjn KtGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X1WDN9LkkfTLodn/7AZmvdlWK3elCwMaUY4+s15zcjs=; b=fuBpCTOSUdi4RILomfEPh7nb4M7TRgAWAOoZwZy7mpdS2oHOymJ0RWUBA790xPFym1 tXg+kvK825F96569hjfNbn9AlijPTC/+iqWQUkJAg47zCMdoFDbABzi2CTV5YH0qxFv4 V1ZJ6oM64WtQlBRe31+F9oWGKLXYdy4gv9QDXy1w4SaTyOUMDgXbtm0HNlq1yHAsyuPK DpZdV15l+c7Q/RVY89dTwxodHU6PfRJKpnINzwiue6X9Q7K47stfaEVKHP482ds28urz rbmmhECnptjVxG8UUP2u0IRtSH46NTrWbV63sfXDQN5EPh2H4ZP+tMGeI+gptxhLwfux V6RQ== X-Gm-Message-State: AOAM531deycuUeCQxirZSShPweHNPee/r78L7RscAxCTuIhE9WAxraee ssYDAf1fBwoVB0WArqzG0503Q0LvkrdMI/C42Bd0Gg== X-Google-Smtp-Source: ABdhPJyH8Es5S0fiHP/hznaMowGfa4CiQ/5DqH3eELfDWrap1a8f9HW2gm8T83Kn6nYavVuv3RpCOGtt2aCb7jKivCo= X-Received: by 2002:a05:651c:160e:: with SMTP id f14mr7064711ljq.273.1626567424296; Sat, 17 Jul 2021 17:17:04 -0700 (PDT) MIME-Version: 1.0 References: <1626430843-23823-1-git-send-email-dillon.minfei@gmail.com> <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Sun, 18 Jul 2021 02:16:53 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings To: dillon min Cc: "thierry.reding@gmail.com" , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Doug Anderson , Alexandre Torgue , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Dillon, thanks for your patch! On Fri, Jul 16, 2021 at 12:20 PM wrote: > From: Dillon Min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: Dillon Min > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) This is a DBI feature so mention in the description that this is a DBI panel. > + spi-3wire: true > + > + spi-max-frequency: > + const: 10000000 > + > + port: true > + > +additionalProperties: false Please add regulator supplies for the power lines, it's fine not to implement code handling them in the driver but they should be in the bindings. For the ili9341 it should be vci-supply: description: Analog voltage supply (2.5 .. 3.3V) vddi-supply: description: Voltage supply for interface logic (1.65 .. 3.3 V) vddi-led-supply: description: Voltage supply for the LED driver (1.65 .. 3.3 V) Yours, Linus Walleij