From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states during low-power Date: Fri, 22 Sep 2017 15:03:45 +0200 Message-ID: References: <20170921010421.7467-1-f.fainelli@gmail.com> <20170921010421.7467-3-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170921010421.7467-3-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Florian Fainelli , ext Tony Lindgren Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren , Andy Shevchenko , Al Cooper , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Mark Rutland , bcm-kernel-feedback-list List-Id: devicetree@vger.kernel.org On Thu, Sep 21, 2017 at 3:04 AM, Florian Fainelli wrote: > Some platforms (e.g: Broadcom STB: BMIPS_GENERIC/ARCH_BRCMSTB) will lose > their register contents when entering their lower power state. In such a > case, the pinctrl-single driver that is used will not be able to restore > the power states without telling the core about it and having > pinctrl_select_state() check for that. > > This patch adds a new optional boolean property that Device Tree can > define in order to obtain exactly that and having the core pinctrl code > take that into account. > > Signed-off-by: Florian Fainelli If we use this per-controller approach rather than the per-state approach I discuss in reply to patch 1/2, we should probably make it a generic property for pin controllers and not just a pinctrl-single business. So patch pinctrl-bindings.txt and put the code somewhere in core. But that is more of a detail, first we need to figure out how to handle this business in general. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html