From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A014B146A8A for ; Fri, 26 Jul 2024 20:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722026256; cv=none; b=U6Z6bnet6GOddfmpj/Ba6rA+w/EBYphbsn/ajwN1vxfvlkVMSfRx2RoVs5y1QXxImw9EaTVdoRhGRDhkueLbKeH9IO0IDune0uL5xjjtrQaDfnexftA44CMUfOTRxApFbTvqVjwyoBoovfoCV2ufBjwhV2Wl3k1vdB3jY/MgB3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722026256; c=relaxed/simple; bh=VpFGnpRR5hkWzh8gvesZMOzSfdyh684K/16SG0UCRpc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=jNqlALcXtXjZGSNoMNOwFd8p2eJjWMfKUANwAH9JWVkE0WzUhQkFD4p1M2pVVWCjLhz/MzgLtuMeuwm3EcuTeb3uzWPw3bUbohBGIyJBNzIa54zxmvtNGg+q8ap+q6qWZw/TeO6/pgLXaZOAX1lN7c8l+ofjCcRuYkJBV6yaxZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U6UlP8A6; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U6UlP8A6" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52f01b8738dso1846166e87.1 for ; Fri, 26 Jul 2024 13:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722026253; x=1722631053; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=657P5JeC8SjYcUxgWCTWkbvBvs/fWchllBX/2A8VqhE=; b=U6UlP8A6jqlkui3uZh6xk5RE5GUgU0wW0VLnTMiXsGjQ1eJk0HwMzl/YUWKEz/VAZw dtLKq9FLjDsDIxk9SyicT7SQ1BtLXq5Bsnaky6fTwN3MiridOQSKKATk6WtpWOcTUBPl c8e4sLWuAEXoQhgEjmRXoPIw41gHB2GpLrJYAEjnvMGdR1zzBj4JS619zRVW0f8IUHCN qz2glptWV0H8Fk/e/mHA0Ibm71gDUWJJPG05XoOAQg5wKGSFPb+7QDpiqRF8Eodcy5lQ JptP5hERs1VZYD7iFgm1VTYyYBjUu7Nw8d58x9KfH0lkXl9PjojVcmUE1Gk9zIO7XyCf OijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722026253; x=1722631053; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=657P5JeC8SjYcUxgWCTWkbvBvs/fWchllBX/2A8VqhE=; b=OOz+nH+J9zTbC1AfmJ1cIYKTiwgRAdbutNNWlIMMOeU2CpF0RMiV54005a3EGkkKmf CYvQ37KvS+RNdhatEZaEXMlSySYzjkHYA+MiysIJXk+3wwfAKe0d6NnBn3lE3rFoiN2l ped0t7WredkqlH+0Mb1RGA1+z9FaxyImNxdgAimsV2vivhA5Ivus0/3T7z+yL8h1wRr/ y7Y23ZGUlX757asecPFaDALrblH5PTu/vep+qT1nVjakl7PNgckNW/+HCT5VEmOJlixi 9NQgh37YATyRrmWbB/xolrLj9Yyudp/1zRmXF5Jv2he4iEYYddCXTxhCN03rBWbzeNba Ti6g== X-Forwarded-Encrypted: i=1; AJvYcCWUdVDc8VIKqLWaQ9LKk2FYEJGwQOGyyOwmL0XLShLpG2Ehe28bFKP0NAXGEpD955TvdmSQW0jwctwD0TR4aRA1XgAHd21VrHXA3A== X-Gm-Message-State: AOJu0YxN5FzLKKZ51Xqq8La3ejAV+kP5ngZOhIBieiT7QJ+NK0bRqURp 0yxxpoQRAlkRF0ePStbLSGJEVeOQnqkQNDo+L9GGTfIUEpMQjDAKk0ELB6Xt+c4aHIeUHMxWzKm voye706uAMSd9MtkLrZNhpG7VXaPiQZb3CoNa3A== X-Google-Smtp-Source: AGHT+IHJKjb7DhnOe6IE0tF8j9C9EWdehdE6mzT6mGSHyOSD6devxjVA8ebqqDI8599aitXQ59+ccERwN/3nlh8FY+w= X-Received: by 2002:a05:6512:246:b0:52c:d967:79c6 with SMTP id 2adb3069b0e04-5309b270bd5mr545733e87.20.1722026252672; Fri, 26 Jul 2024 13:37:32 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240722160022.454226-1-valentin.caron@foss.st.com> In-Reply-To: <20240722160022.454226-1-valentin.caron@foss.st.com> From: Linus Walleij Date: Fri, 26 Jul 2024 22:37:21 +0200 Message-ID: Subject: Re: [PATCH v3 0/4] rtc: stm32: add pinctrl interface to handle RTC outs To: Valentin Caron Cc: Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Amelie Delaunay Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Valentin, On Mon, Jul 22, 2024 at 6:02=E2=80=AFPM Valentin Caron wrote: > This series adds a pinctrl/pinmux interface to control STM32 RTC outputs. Interesting! I think it is the first pin controller outside on drivers/pinctrl in the kernel tree. Please include me and the linux-gpio@vger.kernel.org list in subsequent postings, I want to be sure what gets merged here and I only noticed this from the LWN driver patches summary. > As device-trees will be upstreamed separately, here is an example: > > stm32-pinctrl { > rtc_rsvd_pins_a: rtc-rsvd-0 { > pins { > pinmux =3D , /* OUT2 */ > ; /* OUT2_RMP */ > }; > }; > }; > > stm32-rtc { > pinctrl-0 =3D <&rtc_rsvd_pins_a &rtc_alarma_pins_a>; So the first one is a generic pin control setting and the second one is a hog for the pins defined by the device itself. It's clever, and works. Nice work! (There should probably be a comment in the device tree to say what is going on so people reading it are not confused.) > /* Enable by foo-device */ > rtc_lsco_pins_a: rtc-lsco-0 { > pins =3D "out2_rmp"; > function =3D "lsco"; > }; > > /* Enable by stm32-rtc hog */ > rtc_alarma_pins_a: rtc-alarma-0 { > pins =3D "out2"; > function =3D "alarm-a"; > }; Yours, Linus Walleij