From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D1FC2D0E4 for ; Tue, 17 Nov 2020 21:00:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45B8B241A5 for ; Tue, 17 Nov 2020 21:00:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jFWNWp2T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbgKQU7T (ORCPT ); Tue, 17 Nov 2020 15:59:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgKQU7T (ORCPT ); Tue, 17 Nov 2020 15:59:19 -0500 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0533C0617A6 for ; Tue, 17 Nov 2020 12:59:18 -0800 (PST) Received: by mail-lj1-x242.google.com with SMTP id 11so25934359ljf.2 for ; Tue, 17 Nov 2020 12:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lhOVKceVBv7kVKCgOWNBzO70XQrC0EF5U4LspVOWhdQ=; b=jFWNWp2TgwOeIaJn/jRrE7BtuYTGCLhCbYE1gTAv9xgjHbnUiLNIEgwBwRvKlTP/bW EYstaUc5JEc0i4QC2VMllWpVxHobX2i95V0FGI/LQF35NIJjY9Pn96rE2RzgO588ungl EXiEGgjrT3HGHa4BzkBHA5XlatVXLUwTAANULsOvBtkNeGKIFfqsqwrxasdbzxiFLpoZ jOhE37cjXz3dN7vSaw2HY19SCUhSz0AkicBVW49Ovamx3xoTaRKO7MgaJkI+oTEcIeoY k9GBD+p52hRY5liL5DAx6xBuZH1JDEFrh6/uuxfbnU+tma0kHkEcZX2ImRsdqCo9WCZN t7rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lhOVKceVBv7kVKCgOWNBzO70XQrC0EF5U4LspVOWhdQ=; b=O7PfczmfqGonPPLCesPn6doOz+G/WlS1V+SDYvGd2yT8gNe7TpM0K6Di+jWiXmJPHw f4IsXzub9xbi35nyoSd1H6clRavTTTFPPM2DkUs4veeJzWO381LouG+ow6JbmEp+697I AC0t6ZjyVAaqEmPRo5YfHAovgJrPoP+B4lGfQZWdJlU4wRBwHpTxlImmURgPqD6T6CBJ Opa1i/3MdkjfXoLMOxyj6pkU5bwUIUiH/jmqL2VzM+9hUuvEO6704XtO0covlLAxgz1a /7Q3IpJpADKtbSIg64smbkN050YUXghPrs5WCrnuVxYAgyTzToUuGiu4WsY0s2f3zD7m sFmg== X-Gm-Message-State: AOAM5336Qi2TLRhlJbWTMxh86gBv6m8vLxOldxOkl4eF9vclUGhl56mp 5uUv5FsnKSgxW4zDLV5zT2PRANiEGT21D+OzQAaE6Q== X-Google-Smtp-Source: ABdhPJxjUwnRMlyZ1I6GdoT/R74osOxNheL4gleSpdaSISqhkb43ujnEF7gLzIuthlDegCWIFpbwtFMORGY7wdDa0eU= X-Received: by 2002:a2e:321a:: with SMTP id y26mr2883348ljy.293.1605646757115; Tue, 17 Nov 2020 12:59:17 -0800 (PST) MIME-Version: 1.0 References: <20201112084057.1399983-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20201112084057.1399983-3-nobuhiro1.iwamatsu@toshiba.co.jp> In-Reply-To: <20201112084057.1399983-3-nobuhiro1.iwamatsu@toshiba.co.jp> From: Linus Walleij Date: Tue, 17 Nov 2020 21:59:06 +0100 Message-ID: Subject: Re: [PATCH v2 2/4] gpio: visoconti: Add Toshiba Visconti GPIO support To: Nobuhiro Iwamatsu Cc: Rob Herring , Punit Agrawal , yuji2.ishikawa@toshiba.co.jp, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Nobuhiro, On Thu, Nov 12, 2020 at 12:42 AM Nobuhiro Iwamatsu wrote: > Add the GPIO driver for Toshiba Visconti ARM SoCs. > > Signed-off-by: Nobuhiro Iwamatsu I just noticed this: > +config GPIO_VISCONTI > + tristate "Toshiba Visconti GPIO support" > + depends on ARCH_VISCONTI || COMPILE_TEST > + depends on OF_GPIO > + select GPIOLIB_IRQCHIP > + help > + Say yes here to support GPIO on Tohisba Visconti. Add: select GPIO_GENERIC Then all of these: > +static int visconti_gpio_get(struct gpio_chip *chip, unsigned int offset) > +static void visconti_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) > +static int visconti_gpio_get_dir(struct gpio_chip *chip, unsigned int offset) > +static int visconti_gpio_dir_in(struct gpio_chip *chip, unsigned int offset) > +static int visconti_gpio_dir_out(struct gpio_chip *chip, unsigned int offset, int value) Can be implemented by the genric MMIO GPIO library. > + gpio_chip = &priv->gpio_chip; > + gpio_chip->label = name; > + gpio_chip->owner = THIS_MODULE; > + gpio_chip->parent = dev; > + gpio_chip->request = gpiochip_generic_request; > + gpio_chip->free = gpiochip_generic_free; > + gpio_chip->get = visconti_gpio_get; > + gpio_chip->set = visconti_gpio_set; > + gpio_chip->get_direction = visconti_gpio_get_dir; > + gpio_chip->direction_input = visconti_gpio_dir_in; > + gpio_chip->direction_output = visconti_gpio_dir_out; > + gpio_chip->base = 0; > + gpio_chip->ngpio = VISCONTI_GPIO_NR; > + gpio_chip->irq.init_valid_mask = visconti_init_irq_valid_mask; Initialized the generic helpers using the addresses of the GPIO registers here by a call to bgpio_init(). Check this driver for an example: drivers/gpio/gpio-ftgpio010.c If you get uncertain about the arguments to bgpio_init() check drivers/gpio/gpio-mmio.c, there is kerneldoc for the function. By doing this you get implementations of gpio_[get|set]_multiple() for free. Yours, Linus Walleij