From: Linus Walleij <linus.walleij@linaro.org>
To: Joel Selvaraj <jo@jsfamily.in>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Corentin Labbe <clabbe@baylibre.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Hao Fang <fanghao11@huawei.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel: introduce ebbg,ft8719 panel
Date: Fri, 13 May 2022 22:39:45 +0200 [thread overview]
Message-ID: <CACRpkdbvv6FcdatAPdTq4fmzgXyr-SjYEwuc_sT+152DtqhiUw@mail.gmail.com> (raw)
In-Reply-To: <BY5PR02MB70098FF9BDEDE264B78CFCE0D9C89@BY5PR02MB7009.namprd02.prod.outlook.com>
On Wed, May 11, 2022 at 7:28 AM Joel Selvaraj <jo@jsfamily.in> wrote:
> Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode
> panel, which can be found on some Xiaomi Poco F1 phones. The panel's
> backlight is managed through QCOM WLED driver.
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
I see my review comments on v1 arrived after v2.
Nevertheless, please address my review comments on v1.
> +struct ebbg_ft8719 {
> + struct drm_panel panel;
> + struct mipi_dsi_device *dsi;
> +
> + struct regulator_bulk_data supplies[ARRAY_SIZE(regulator_names)];
> +
> + struct gpio_desc *reset_gpio;
> + bool prepared;
For example that means to drop this prepared member.
Yours,
Linus Walleij
prev parent reply other threads:[~2022-05-13 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1652245767.git.jo@jsfamily.in>
2022-05-11 5:28 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG Joel Selvaraj
2022-05-11 8:20 ` Krzysztof Kozlowski
2022-05-11 15:54 ` Joel Selvaraj
2022-05-11 5:28 ` [PATCH v2 2/3] dt-bindings: display: Add bindings for EBBG FT8719 Joel Selvaraj
2022-05-11 8:22 ` Krzysztof Kozlowski
2022-05-13 20:28 ` Linus Walleij
2022-05-11 5:28 ` [PATCH v2 3/3] drm/panel: introduce ebbg,ft8719 panel Joel Selvaraj
2022-05-11 17:39 ` Sam Ravnborg
2022-05-13 20:39 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbvv6FcdatAPdTq4fmzgXyr-SjYEwuc_sT+152DtqhiUw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=airlied@linux.ie \
--cc=clabbe@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fanghao11@huawei.com \
--cc=jo@jsfamily.in \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=stano.jakubek@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).