From: Linus Walleij <linus.walleij@linaro.org>
To: Beniamino Galvani <b.galvani@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Carlo Caione <carlo@caione.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jerry Cao <jerry.cao@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>
Subject: Re: [PATCH v2 2/3] pinctrl: meson: add device tree bindings documentation
Date: Tue, 28 Oct 2014 15:21:09 +0100 [thread overview]
Message-ID: <CACRpkdbw-Rdm9PoOfbmLApJX-df5Kcmag4a=GHV58Y7T=1ykQg@mail.gmail.com> (raw)
In-Reply-To: <1413321714-25931-3-git-send-email-b.galvani@gmail.com>
On Tue, Oct 14, 2014 at 11:21 PM, Beniamino Galvani <b.galvani@gmail.com> wrote:
> Add device tree bindings documentation for Amlogic Meson pinmux and
> GPIO controller.
>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
(...)
> + gpio_ao: ao-bank@c1108030 {
> + reg = <0xc8100014 0x4>,
> + <0xc810002c 0x4>,
> + <0xc8100024 0x8>;
This still has the same problem as in the previous review.
It seems for both patches you posted v2 before I got to review
v1, so sorry for the confusion.
Please take the combined result of my review letters and
fix everything...
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-10-28 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 21:21 [PATCH v2 0/3] Pinctrl driver for Amlogic Meson SoCs Beniamino Galvani
2014-10-14 21:21 ` [PATCH v2 1/3] pinctrl: add " Beniamino Galvani
2014-10-28 14:19 ` Linus Walleij
2014-10-14 21:21 ` [PATCH v2 2/3] pinctrl: meson: add device tree bindings documentation Beniamino Galvani
2014-10-28 14:21 ` Linus Walleij [this message]
2014-10-14 21:21 ` [PATCH v2 3/3] ARM: dts: meson8: add pinctrl and gpio nodes Beniamino Galvani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbw-Rdm9PoOfbmLApJX-df5Kcmag4a=GHV58Y7T=1ykQg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=b.galvani@gmail.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jerry.cao@amlogic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).