From: Linus Walleij <linus.walleij@linaro.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Jonathan Santos <Jonathan.Santos@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
lars@metafoo.de, Michael.Hennerich@analog.com,
marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, jonath4nns@gmail.com,
marcelo.schmitt1@gmail.com
Subject: Re: [PATCH RESEND v3 12/17] iio: adc: ad7768-1: Add GPIO controller support
Date: Fri, 28 Feb 2025 09:52:15 +0100 [thread overview]
Message-ID: <CACRpkdbw3BkpzPQp2PdV8M61V2XXaLcmuOpGTsxSoiQTH7wZXw@mail.gmail.com> (raw)
In-Reply-To: <7c5e2364-038b-48a8-ad67-3cf0f2fd2be3@baylibre.com>
On Thu, Feb 20, 2025 at 11:27 PM David Lechner <dlechner@baylibre.com> wrote:
> On 2/19/25 2:34 PM, Linus Walleij wrote:
> > Is it not possible to use the gpio regmap library in this driver
> > like we do in drivers/iio/addac/stx104.c?
> >
> > It cuts down the code size of simple GPIO chips on random
> > chips quite a lot.
>
> I think the answer is "no" since we need to hold a conditional lock
> while accessing registers. Namely: iio_device_claim_direct_mode()/
> iio_device_release_direct_mode().
Sorry for potentially dumb question, but if this is required to access
the registers, why is it not done in the regmap abstraction itself?
It's kind of that stuff regmap is supposed to hide.
Yours,
Linus Walleij
next prev parent reply other threads:[~2025-02-28 8:52 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 18:15 [PATCH RESEND v3 00/17] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-02-12 18:15 ` [PATCH RESEND v3 01/17] iio: adc: ad7768-1: Fix conversion result sign Jonathan Santos
2025-02-12 18:16 ` [PATCH RESEND v3 02/17] iio: adc: ad7768-1: set MOSI idle state to prevent accidental reset Jonathan Santos
2025-02-16 15:59 ` Jonathan Cameron
2025-02-12 18:16 ` [PATCH RESEND v3 03/17] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-02-13 20:24 ` Conor Dooley
2025-02-27 21:30 ` Jonathan Santos
2025-03-21 14:39 ` Rob Herring
2025-02-12 18:16 ` [PATCH RESEND v3 04/17] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-02-12 18:16 ` [PATCH RESEND v3 05/17] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-02-13 20:25 ` Conor Dooley
2025-02-20 21:22 ` David Lechner
2025-02-12 18:16 ` [PATCH RESEND v3 06/17] Documentation: ABI: add wideband filter type to sysfs-bus-iio Jonathan Santos
2025-02-20 21:28 ` David Lechner
2025-02-22 11:51 ` Jonathan Cameron
2025-02-12 18:17 ` [PATCH RESEND v3 07/17] iio: adc: ad7768-1: remove unnecessary locking Jonathan Santos
2025-02-20 21:30 ` David Lechner
2025-02-12 18:17 ` [PATCH RESEND v3 08/17] iio: adc: ad7768-1: convert driver to use regmap Jonathan Santos
2025-02-16 16:06 ` Jonathan Cameron
2025-02-20 21:41 ` David Lechner
2025-02-12 18:17 ` [PATCH RESEND v3 09/17] iio: adc: ad7768-1: Add reset gpio Jonathan Santos
2025-02-12 18:17 ` [PATCH RESEND v3 10/17] iio: adc: ad7768-1: Move buffer allocation to a separate function Jonathan Santos
2025-02-20 21:43 ` David Lechner
2025-02-12 18:17 ` [PATCH RESEND v3 11/17] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-02-13 22:57 ` kernel test robot
2025-02-16 16:11 ` Jonathan Cameron
2025-02-20 22:20 ` David Lechner
2025-02-12 18:18 ` [PATCH RESEND v3 12/17] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-02-16 16:14 ` Jonathan Cameron
2025-02-19 20:34 ` Linus Walleij
2025-02-20 22:27 ` David Lechner
2025-02-27 21:36 ` Jonathan Santos
2025-02-27 21:54 ` David Lechner
2025-02-28 8:52 ` Linus Walleij [this message]
2025-02-28 15:55 ` David Lechner
2025-03-04 8:03 ` Linus Walleij
2025-02-12 18:18 ` [PATCH RESEND v3 13/17] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-02-20 22:38 ` David Lechner
2025-02-12 18:18 ` [PATCH RESEND v3 14/17] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-02-12 18:18 ` [PATCH RESEND v3 15/17] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-02-16 16:21 ` Jonathan Cameron
2025-02-12 18:18 ` [PATCH RESEND v3 16/17] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-02-16 16:31 ` Jonathan Cameron
2025-02-20 13:28 ` Jonathan Santos
2025-02-12 18:19 ` [PATCH RESEND v3 17/17] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-02-16 16:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbw3BkpzPQp2PdV8M61V2XXaLcmuOpGTsxSoiQTH7wZXw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).