From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06A0C4332F for ; Fri, 4 Nov 2022 14:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbiKDOUq (ORCPT ); Fri, 4 Nov 2022 10:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbiKDOU1 (ORCPT ); Fri, 4 Nov 2022 10:20:27 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8481D3135D for ; Fri, 4 Nov 2022 07:19:49 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id u11so6556121ljk.6 for ; Fri, 04 Nov 2022 07:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lessconfused.com; s=lessconfused; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=voYiNsyY/ek+IToQ07CcYY4mSqrFhgou3qPtSDlDP1k=; b=XRhbm3QbiRh2CLfnWomQBfhuEqdrThEhDEBRNtSNBbz5ba50fEhbTe/19ySlo61bP/ fXL/vtM7oizgNn06YBpUeewCIwQWwwBZv6Kc5ijGbGo3jAS6PFB6RuhcrEMWf461JiGF icTWxx/P//aLL4p3m5WyWjjGNUIVi6/C5FI7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=voYiNsyY/ek+IToQ07CcYY4mSqrFhgou3qPtSDlDP1k=; b=i1a2gHrKZzCkkDX9TfJb4wXIkorik7GSHPmwsY8JmqJwshCED9g9sVavSfM7UU69lO bXvKTyhEICFLb/8lzVzo0YESP76j9T5Gkt//WNJT6C/ODMJTwjCl95YDqrdnV/eySJ8k YUKyu04T3wlZhGbhQSNsVynb9Pxls6TM0JboUT4c5Yk5HRqf70TEsyCpyoUgOewBcAz9 CtOmXd8X5rI0yB//N/SBU5eNyIf1iUY8OsKSLliBKdynLE+rsEWhiu826DoJCdJsdZvg oOVFCPAGL3fWUXVIxiY6wXGYwYV2SPACNaTWYKcRZkFhx3m6x9dku46F7du7h60Ul4J/ A3Aw== X-Gm-Message-State: ACrzQf1Ex8cf0YaiysUijh5QHXd8rbyuDwg+TqUs7Ol/0K+Y81Z5cuXo mSs8ptQx/qZDShPLFIv2Uy1mBGxaQ8tkQP9E31kGNg== X-Google-Smtp-Source: AMsMyM520aXMi+FrAZPgy5y0X4+JSH/DVaaHj5aug/Cislo5YHYwrKDaMjtI06Tx1gYVGNzCTjllogi7gQZU8oq2CWs= X-Received: by 2002:a05:651c:11d0:b0:277:f8b:bb4f with SMTP id z16-20020a05651c11d000b002770f8bbb4fmr2238379ljo.161.1667571587275; Fri, 04 Nov 2022 07:19:47 -0700 (PDT) MIME-Version: 1.0 References: <20221104132046.1555932-1-thierry.reding@gmail.com> In-Reply-To: <20221104132046.1555932-1-thierry.reding@gmail.com> From: Da Xue Date: Fri, 4 Nov 2022 10:19:36 -0400 Message-ID: Subject: Re: [PATCH] arm64: rockchip: Remove unknown regulator-init-microvolt property To: Thierry Reding Cc: Heiko Stuebner , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Nov 4, 2022 at 9:22 AM Thierry Reding wrote: > > From: Thierry Reding > > The regulator-init-microvolt is not defined anywhere and not used by any > driver, so remove it from existing device trees. These are used in u-boot: grep -r regulator-init-microvolt doc/device-tree-bindings/regulator/regulator.txt:- regulator-init-microvolt: a init allowed Voltage value doc/device-tree-bindings/regulator/regulator.txt: regulator-init-microvolt = <1800000>; drivers/power/regulator/pwm_regulator.c: priv->init_voltage = dev_read_u32_default(dev, "regulator-init-microvolt", -1); drivers/power/regulator/regulator-uclass.c: uc_pdata->init_uV = dev_read_u32_default(dev, "regulator-init-microvolt", > > Signed-off-by: Thierry Reding > --- > arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 - > arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 3 --- > arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 3 --- > 13 files changed, 29 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > index 7ea48167747c..9232357f4fec 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > @@ -106,7 +106,6 @@ vdd_core: vdd-core { > regulator-name = "vdd_core"; > regulator-min-microvolt = <827000>; > regulator-max-microvolt = <1340000>; > - regulator-init-microvolt = <1015000>; > regulator-settling-time-up-us = <250>; > regulator-always-on; > regulator-boot-on; > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > index a71f249ed384..e9810d2f0407 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > @@ -105,7 +105,6 @@ vdd_core: vdd-core { > regulator-name = "vdd_core"; > regulator-min-microvolt = <827000>; > regulator-max-microvolt = <1340000>; > - regulator-init-microvolt = <1015000>; > regulator-settling-time-up-us = <250>; > regulator-always-on; > regulator-boot-on; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi > index b6e082f1f6d9..7c5f441a2219 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi > @@ -375,7 +375,6 @@ regulator-state-mem { > vcc_sdio: LDO_REG4 { > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <3000000>; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-name = "vcc_sdio"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi > index 41262a69d33e..a71973b16075 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi > @@ -356,7 +356,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_logic"; > @@ -371,7 +370,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_gpu"; > @@ -533,7 +531,6 @@ vdd_cpu: regulator@40 { > regulator-boot-on; > regulator-min-microvolt = <712500>; > regulator-max-microvolt = <1390000>; > - regulator-init-microvolt = <900000>; > regulator-name = "vdd_cpu"; > regulator-ramp-delay = <2300>; > vin-supply = <&vcc_sys>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi > index 8d61f824c12d..d899087bf0b5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi > @@ -264,7 +264,6 @@ vdd_logic: DCDC_REG1 { > regulator-always-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > @@ -278,7 +277,6 @@ vdd_gpu_npu: DCDC_REG2 { > regulator-name = "vdd_gpu_npu"; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts > index 25a8c781f4e7..854d02b46e6f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts > @@ -366,7 +366,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_logic"; > @@ -381,7 +380,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_gpu"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > index 77b179cd20e7..fc38b30d3722 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > @@ -277,7 +277,6 @@ vdd_log: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > @@ -292,7 +291,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts > index 61c7a3ad7387..45807d7e22eb 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts > @@ -250,7 +250,6 @@ vdd_log: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > @@ -263,7 +262,6 @@ vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > index 5bcd4be32964..e23e2293d10a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > @@ -192,7 +192,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-state-mem { > @@ -207,7 +206,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-state-mem { > @@ -230,7 +228,6 @@ vdd_npu: DCDC_REG4 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_npu"; > regulator-state-mem { > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > index 26d7fda275ed..a70b89e39dd6 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > @@ -301,7 +301,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -315,7 +314,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -339,7 +337,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > index 674792567fa6..19f8fc369b13 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > @@ -293,7 +293,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -307,7 +306,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -331,7 +329,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > index 59ecf868dbd0..a337f547caf5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > @@ -291,7 +291,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -305,7 +304,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -329,7 +327,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index ea74ba32fbbd..482c892567de 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -340,7 +340,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -354,7 +353,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -378,7 +376,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > -- > 2.38.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip