From: Prashant Malani <pmalani@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Pin-yen Lin" <treapking@chromium.org>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <robert.foss@linaro.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Stephen Boyd" <swboyd@chromium.org>,
dri-devel@lists.freedesktop.org,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-acpi@vger.kernel.org, "Marek Vasut" <marex@denx.de>,
"Xin Ji" <xji@analogixsemi.com>, "Lyude Paul" <lyude@redhat.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org,
"Allen Chen" <allen.chen@ite.com.tw>
Subject: Re: [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks
Date: Thu, 24 Nov 2022 21:53:35 -0800 [thread overview]
Message-ID: <CACeCKaewXJYUJCyGyh==dsA6wsU4OESXFXJRiKm9AWPECS_ZBA@mail.gmail.com> (raw)
In-Reply-To: <Y39ikbcqx5/pEc64@smile.fi.intel.com>
Hi Andy,
Thanks for taking a look at this patch.
Pin-Yen beat me to the punch with comment responses, but I'll add mine anyway.
On Thu, Nov 24, 2022 at 4:25 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> ...
>
> > + /*
> > + * OF graph may have set up some device links with switches, since connectors have their
> > + * own compatible. Purge these to avoid a deadlock in switch probe (the switch mistakenly
> > + * assumes the connector is a supplier).
> > + */
>
> A bit too long lines...
They are within the 100 character limit [1] which is followed
elsewhere in the driver; has something
changed recently to make that invalid?
>
> > + if (dev->of_node)
>
> Why do you need this check?
This issue only arises when using DT for this device. So the rationale
is we don't need to
perform this step on systems that don't use DT.
Best regards,
-Prashant
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
next prev parent reply other threads:[~2022-11-25 5:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 10:20 [PATCH v6 0/7] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin
2022-11-24 10:20 ` [PATCH v6 1/7] device property: Add remote endpoint to devcon matcher Pin-yen Lin
2022-11-24 10:20 ` [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Pin-yen Lin
2022-11-24 12:24 ` Andy Shevchenko
2022-11-25 5:52 ` Pin-yen Lin
2022-11-25 5:53 ` Prashant Malani [this message]
2022-11-24 10:20 ` [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Pin-yen Lin
2022-11-24 17:39 ` Rob Herring
2022-11-25 3:58 ` Pin-yen Lin
2022-11-27 20:58 ` Krzysztof Kozlowski
2022-12-26 8:49 ` Pin-yen Lin
2022-11-24 10:20 ` [PATCH v6 4/7] drm/bridge: anx7625: Check for Type-C during panel registration Pin-yen Lin
2022-11-24 10:20 ` [PATCH v6 5/7] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin
2022-11-24 12:18 ` Andy Shevchenko
2022-11-25 6:58 ` Pin-yen Lin
2022-11-24 10:20 ` [PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support Pin-yen Lin
2022-11-24 17:39 ` Rob Herring
2022-11-25 3:58 ` Pin-yen Lin
2022-11-27 21:02 ` Krzysztof Kozlowski
2022-12-26 8:57 ` Pin-yen Lin
2022-11-24 10:20 ` [PATCH v6 7/7] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin
2022-11-24 12:23 ` Andy Shevchenko
2022-11-25 6:55 ` Pin-yen Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACeCKaewXJYUJCyGyh==dsA6wsU4OESXFXJRiKm9AWPECS_ZBA@mail.gmail.com' \
--to=pmalani@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=allen.chen@ite.com.tw \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=rafael@kernel.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).