From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB750C4332F for ; Fri, 25 Nov 2022 05:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbiKYFxt (ORCPT ); Fri, 25 Nov 2022 00:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiKYFxs (ORCPT ); Fri, 25 Nov 2022 00:53:48 -0500 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C15C31AD91 for ; Thu, 24 Nov 2022 21:53:47 -0800 (PST) Received: by mail-qk1-x735.google.com with SMTP id k2so2083885qkk.7 for ; Thu, 24 Nov 2022 21:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sJO4CKtz6uCVjlMUGm3BSASo1KZZ4zekB4W49uCXr0Q=; b=GEQWK1zMTOaNgc6Jsw7BvrlA2RvLaRBKdutwd2mWXuN32GcN/F/lh7Do+jJwhu/lKf eUQzy4v825QJ8od3gmSFrmEbBs06XRTg2khVxN2jX2t/NUFG68evKAZHk2uGyqoEdH/l BYs68ifkf0D5ULeS+KO0T9nvkikk56lTOVFYw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sJO4CKtz6uCVjlMUGm3BSASo1KZZ4zekB4W49uCXr0Q=; b=TpWMjCJvd01nw5BacLHHMp0hBR5A1Y+tjoW6MFGGAWFclztYzsODn0p4hGgu5JhDd2 tju/i0jOFBUTMGrNeYQe4bYbTsG/cBV6NsTKC4WkNr/1xQPS3iLrVx/SbJC5KC+1Ktko DN9c87tYlniR/7J2lrDEfgPvZHPQ7XehPtkde+CjUuTYqV5ovbC5qQm9t/TeEYbfR0F2 qTJe3TQuG6JZIkGVZ4WCyWczLQOF6uWy/E1Hr4p8xgeC+Or6PKbgwNJMWCSZwYue/Ir9 tPNdxwu/na7ukyrE5SnsfX4neK8PzsMtD5tBr48Cjk9ddiUGvrelWqbGJxquN5ieEO3V i/1A== X-Gm-Message-State: ANoB5pmsDMeEAoKPeaS9sEZ8XnUGCHDdl59mMXGy93sfKNf0t5MU3GYV iB19RyAGay9rv17wEEHrie2X1bZjSL0yXFMMAdikPQ== X-Google-Smtp-Source: AA0mqf6knSu6QR92mZ0wCOhRti8BSXDFhhs9fIvKI9CaT08+1NzMdooQC08kJNAEDw9GfohzPzP4gUJ+R3xq6VWqYa4= X-Received: by 2002:a05:620a:31a5:b0:6fb:ff0f:e7e0 with SMTP id bi37-20020a05620a31a500b006fbff0fe7e0mr19622315qkb.747.1669355626882; Thu, 24 Nov 2022 21:53:46 -0800 (PST) MIME-Version: 1.0 References: <20221124102056.393220-1-treapking@chromium.org> <20221124102056.393220-3-treapking@chromium.org> In-Reply-To: From: Prashant Malani Date: Thu, 24 Nov 2022 21:53:35 -0800 Message-ID: Subject: Re: [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks To: Andy Shevchenko Cc: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Benson Leung , Guenter Roeck , Javier Martinez Canillas , Stephen Boyd , dri-devel@lists.freedesktop.org, Hsin-Yi Wang , Thomas Zimmermann , devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-acpi@vger.kernel.org, Marek Vasut , Xin Ji , Lyude Paul , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, Allen Chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Andy, Thanks for taking a look at this patch. Pin-Yen beat me to the punch with comment responses, but I'll add mine anyway. On Thu, Nov 24, 2022 at 4:25 AM Andy Shevchenko wrote: > ... > > > + /* > > + * OF graph may have set up some device links with switches, since connectors have their > > + * own compatible. Purge these to avoid a deadlock in switch probe (the switch mistakenly > > + * assumes the connector is a supplier). > > + */ > > A bit too long lines... They are within the 100 character limit [1] which is followed elsewhere in the driver; has something changed recently to make that invalid? > > > + if (dev->of_node) > > Why do you need this check? This issue only arises when using DT for this device. So the rationale is we don't need to perform this step on systems that don't use DT. Best regards, -Prashant [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144