From: Tai Tri Nguyen <ttnguyen@apm.com>
To: Joe Perches <joe@perches.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
catalin.marinas@arm.com,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Duc Dang <dhdang@apm.com>, LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
patches <patches@apm.com>
Subject: Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver
Date: Thu, 14 Jul 2016 10:54:45 -0700 [thread overview]
Message-ID: <CACgAJHwzWG_6iWG4OcL3v5QcUF892DwBcJxayqbH4f2kd7=kQQ@mail.gmail.com> (raw)
In-Reply-To: <1468518428.8745.43.camel@perches.com>
Hi Joe,
On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote:
>> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware
>> found in APM X-Gene SoCs.
>
> trivia:
>
>> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> []
>> +struct xgene_pmu_dev_ctx {
>> + char *name;
>> + struct list_head next;
>> + struct xgene_pmu_dev *pmu_dev;
>> + struct hw_pmu_info inf;
>> +};
>
> Probably better to use something like
> char name[20];
> as the kasprintf can fail and this doesn't
> seem to be freed anywhere.
Okay. I'll fix it shortly.
[...]
Thanks,
--
Tai
next prev parent reply other threads:[~2016-07-14 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 17:27 [PATCH v9 0/4] perf: Add APM X-Gene SoC Performance Monitoring Unit driver Tai Nguyen
2016-07-14 17:27 ` [PATCH v9 1/4] MAINTAINERS: Add entry for APM X-Gene SoC PMU driver Tai Nguyen
2016-07-14 17:27 ` [PATCH v9 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding Tai Nguyen
2016-07-14 17:27 ` [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver Tai Nguyen
2016-07-14 17:47 ` Joe Perches
2016-07-14 17:54 ` Tai Tri Nguyen [this message]
[not found] ` <CACgAJHwzWG_6iWG4OcL3v5QcUF892DwBcJxayqbH4f2kd7=kQQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-14 18:05 ` Tai Tri Nguyen
2016-07-15 9:45 ` Mark Rutland
2016-07-15 17:31 ` Tai Tri Nguyen
2016-07-14 17:27 ` [PATCH v9 4/4] arm64: dts: apm: Add APM X-Gene SoC PMU DTS entries Tai Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACgAJHwzWG_6iWG4OcL3v5QcUF892DwBcJxayqbH4f2kd7=kQQ@mail.gmail.com' \
--to=ttnguyen@apm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dhdang@apm.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@apm.com \
--cc=paul.gortmaker@windriver.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).