devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
To: Boris BREZILLON <b.brezillon.dev@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	linux-doc@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Mike Turquette <mturquette@linaro.org>,
	Boris BREZILLON <brezillonboris@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 09/11] ARM: at91/dt: define main xtal frequency of the at91sam9261ek board
Date: Thu, 20 Mar 2014 11:09:53 +0100	[thread overview]
Message-ID: <CACh+v5Psjgs=v2feP3oETXgxUXw6JsVDXBKhEG4OPCP1-YM1aQ@mail.gmail.com> (raw)
In-Reply-To: <532AB9EC.1030507@gmail.com>

That's right. I keep forgetting this.

2014-03-20 10:50 GMT+01:00 Boris BREZILLON <b.brezillon.dev@gmail.com>:
>
> Le 20/03/2014 10:24, Jean-Jacques Hiblot a écrit :
>
>> 2014-03-18 21:18 GMT+01:00 Boris BREZILLON <brezillonboris@gmail.com>:
>>>
>>> Define at91sam9261ek main crystal frequency.
>>>
>>> Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
>>> ---
>>>   arch/arm/boot/dts/at91sam9261ek.dts |    4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/at91sam9261ek.dts
>>> b/arch/arm/boot/dts/at91sam9261ek.dts
>>> index 2ce527e..7175986 100644
>>> --- a/arch/arm/boot/dts/at91sam9261ek.dts
>>> +++ b/arch/arm/boot/dts/at91sam9261ek.dts
>>> @@ -29,6 +29,10 @@
>>>                          compatible = "atmel,osc", "fixed-clock";
>>>                          clock-frequency = <18432000>;
>>>                  };
>>> +
>>> +               main_xtal: main_xtal {
>>> +                       clock-frequency = <18432000>;
>>> +               };
>>>          };
>>>
>>>          ahb {
>>> --
>>> 1.7.9.5
>>>
>> You forgot to remove the old fixed-clock definition for the main_clock:
>> clock@0
>
>
> We need this clock when CCF is disabled (when using the old at91 clk
> implementation).
> I'm afraid we'll have to keep it until we move all sam9 SoCs and boards to
> CCF (and DT).
>
> Best Regards,
>
> Boris
>
>>
>> Otherwise:
>> Acked-by: Jean-Jacques HIBLOT <jjhiblot@traphandler.com>
>
>

  reply	other threads:[~2014-03-20 10:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 20:18 [PATCH 00/11] ARM: at91: rework main and slow clk implementation Boris BREZILLON
2014-03-18 20:18 ` [PATCH 01/11] clk: at91: rework main " Boris BREZILLON
2014-03-18 20:18 ` [PATCH 02/11] clk: at91: update main clk documentation Boris BREZILLON
2014-03-18 20:18 ` [PATCH 03/11] clk: at91: add slow clks driver Boris BREZILLON
2014-03-18 20:18 ` [PATCH 04/11] clk: at91: add slow clk documentation Boris BREZILLON
2014-03-18 20:18 ` [PATCH 05/11] ARM: at91/dt: move sama5d3 SoC to the new main/slow clk model Boris BREZILLON
2014-03-18 20:18 ` [PATCH 06/11] ARM: at91/dt: add xtal frequencies to sama5d3xcm boards Boris BREZILLON
2014-03-18 20:18 ` [PATCH 07/11] ARM: at91/dt: add xtal frequencies to sama5d3 xplained board Boris BREZILLON
2014-03-18 20:18 ` [PATCH 08/11] ARM: at91/dt: move at91sam9261 SoC to the new main clock model Boris BREZILLON
     [not found]   ` <1395173924-3648-9-git-send-email-b.brezillon.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-20  9:22     ` Jean-Jacques Hiblot
2014-03-18 20:18 ` [PATCH 09/11] ARM: at91/dt: define main xtal frequency of the at91sam9261ek board Boris BREZILLON
2014-03-20  9:24   ` Jean-Jacques Hiblot
2014-03-20  9:50     ` Boris BREZILLON
2014-03-20 10:09       ` Jean-Jacques Hiblot [this message]
2014-03-18 20:18 ` [PATCH 10/11] ARM: at91/dt: move at91sam9rl SoC to the new slow/main clock models Boris BREZILLON
     [not found]   ` <1395173924-3648-11-git-send-email-b.brezillon.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-19 15:39     ` Alexandre Belloni
2014-03-18 20:18 ` [PATCH 11/11] ARM: at91/dt: define sam9rlek crystal frequencies Boris BREZILLON
2014-03-19 15:40   ` Alexandre Belloni
2014-03-19  8:19 ` [PATCH 00/11] ARM: at91: rework main and slow clk implementation Jean-Jacques Hiblot
     [not found] ` <3485B87A-1832-4EE3-8613-B5165C282397@jcrosoft.com>
2014-03-19  9:48   ` Boris BREZILLON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACh+v5Psjgs=v2feP3oETXgxUXw6JsVDXBKhEG4OPCP1-YM1aQ@mail.gmail.com' \
    --to=jjhiblot@traphandler.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=b.brezillon.dev@gmail.com \
    --cc=brezillonboris@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).