From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3] bcma: use device from DT (brcm, bus-chipcommon) for SoC GPIO chip Date: Tue, 30 Sep 2014 12:41:53 +0200 Message-ID: References: <1411892641-5662-1-git-send-email-zajec5@gmail.com> <1412072546-3529-1-git-send-email-zajec5@gmail.com> <3484902.1UVy7lmJAD@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <3484902.1UVy7lmJAD@wuerfel> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "John W. Linville" , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Hauke Mehrtens , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 30 September 2014 12:36, Arnd Bergmann wrote: > On Tuesday 30 September 2014 12:22:26 Rafa=C5=82 Mi=C5=82ecki wrote: >> @@ -218,6 +218,12 @@ int bcma_gpio_init(struct bcma_drv_cc *cc) >> #if IS_BUILTIN(CONFIG_BCM47XX) >> chip->to_irq =3D bcma_gpio_to_irq; >> #endif >> +#if IS_BUILTIN(CONFIG_OF) >> + if (cc->core->bus->hosttype =3D=3D BCMA_HOSTTYPE_SOC) >> + chip->of_node =3D of_find_compatible_node( >> + bus->host_pdev->dev.of_node,= NULL, >> + "brcm,bus-chipcommon"); >> +#endif >> switch (cc->core->bus->chipinfo.id) { > > This doesn't: you are now searching through all nodes starting at the > axi node rather than searching just through the children. > > I think it would be better with the first change in place to set > chip->of_node to cc->core->dev.of_node, and set that pointer in > bcma_bus_scan by matching the 'reg' number. I think that is what > an earlier version of the bcma DT support did in order to find the > IRQs. We no longer need it for that purpose, but it seems like a > good idea anyway, as I expect other bcma_devices to have similar > requirements to add additional properties. Ohh, of course, I didn't notice that [PATCH v6] bcma: register bcma as device tree driver already contains bcma_of_fill_device. This will simplify my search a lo= t! --=20 Rafa=C5=82 -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html