From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH] ARM: BCM5301X: Specify PHY of USB 2.0 in DT Date: Wed, 1 Jun 2016 21:35:26 +0200 Message-ID: References: <1464808585-14996-1-git-send-email-zajec5@gmail.com> <574F35C3.6050004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <574F35C3.6050004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Florian Fainelli Cc: Hauke Mehrtens , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "open list:BROADCOM BCM5301X ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Jon Mason List-Id: devicetree@vger.kernel.org On 1 June 2016 at 21:21, Florian Fainelli wrote: > On 06/01/2016 12:16 PM, Rafa=C5=82 Mi=C5=82ecki wrote: >> Driver for Northstar USB 2.0 PHY was added in 4.7-rc1 by: >> commit d3feb4067335 ("phy: bcm-ns-usb2: new driver for USB 2.0 PHY o= n >> Northstar"). >> It should be used to let EHCI platform driver init PHY. >> >> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki >> --- >> arch/arm/boot/dts/bcm5301x.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm= 5301x.dtsi >> index 7d4d29b..9300e19 100644 >> --- a/arch/arm/boot/dts/bcm5301x.dtsi >> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >> @@ -140,6 +140,22 @@ >> }; >> }; >> >> + phys { >> + compatible =3D "simple-bus"; >> + ranges =3D <0x00000000 0x18000000 0x00100000>; >> + #address-cells =3D <1>; >> + #size-cells =3D <1>; >> + >> + usb2_phy2: usb2-phy { >> + compatible =3D "brcm,ns-usb2-phy"; >> + reg =3D <0x0000c000 0x1000>; >> + reg-names =3D "dmu"; >> + #phy-cells =3D <0>; >> + clocks =3D <&genpll BCM_NSP_GENPLL_USB_PHY_REF= _CLK>; >> + clock-names =3D "phy-ref-clk"; >> + }; > > You guys need to get everything straigthen up when it comes to busing > and child nodes for bcm53101x.dtsi, why do we need a "simple-bus" nod= e > here which overlaps in part with the brcm-bus-axi node's range? I believed I'm making things cleaner by adding a separated node for PHYs (in the future there will be also USB 3.0 PHY and probably a PCIe PHY). I'm fine with placing this PHY node somewhere else if you think it better fits there. --=20 Rafa=C5=82 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html