Re: [PATCH 2/2] drm/panel: simple: Add support for KOE TX26D202VM0BWA panel

[Emil Velikov <emil.l.velikov@gmail.com>]

On Tue, 2 Jun 2020 at 08:17, Liu Ying <victor.liu@nxp.com> wrote:
>
> This patch adds support for Kaohsiung Opto-Electronics Inc.
> 10.1" TX26D202VM0BWA WUXGA(1920x1200) TFT LCD panel with LVDS interface.
> The panel has dual LVDS channels.
>
> My panel is manufactured by US Micro Products(USMP).  There is a tag at
> the back of the panel, which indicates the panel type is 'TX26D202VM0BWA'
> and it's made by KOE in Taiwan.
>
> The panel spec from USMP can be found at:
> https://www.usmicroproducts.com/sites/default/files/datasheets/USMP-T101-192120NDU-A0.pdf
>
> The below panel spec from KOE is basically the same to the one from USMP.
> However, the panel type 'TX26D202VM0BAA' is a little bit different.
> It looks that the two types of panel are compatible with each other.
> http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b6ecd15..7c222ec 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2200,6 +2200,37 @@ static const struct panel_desc koe_tx14d24vm1bpa = {
>         },
>  };
>
> +static const struct display_timing koe_tx26d202vm0bwa_timing = {
> +       .pixelclock = { 151820000, 156720000, 159780000 },
> +       .hactive = { 1920, 1920, 1920 },
> +       .hfront_porch = { 105, 130, 142 },
> +       .hback_porch = { 45, 70, 82 },
> +       .hsync_len = { 30, 30, 30 },
> +       .vactive = { 1200, 1200, 1200},
> +       .vfront_porch = { 3, 5, 10 },
> +       .vback_porch = { 2, 5, 10 },
> +       .vsync_len = { 5, 5, 5 },
> +};
> +
> +static const struct panel_desc koe_tx26d202vm0bwa = {
> +       .timings = &koe_tx26d202vm0bwa_timing,
> +       .num_timings = 1,
> +       .bpc = 8,
> +       .size = {
> +               .width = 217,
> +               .height = 136,
> +       },
> +       .delay = {
> +               .prepare = 1000,
> +               .enable = 1000,
> +               .unprepare = 1000,
> +               .disable = 1000,
Ouch 1s for each delay is huge. Nevertheless it matches the specs so,
the series is:
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Sam, Thierry I assume you'll merge the series. Let me know if I should
pick it up.

-Emil