From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). Date: Tue, 22 May 2012 17:01:51 -0600 Message-ID: References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> <20120520060802.03CE73E03B8@localhost> <4FBBECC2.10503@gmail.com> <4FBC1807.4050402@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4FBC1807.4050402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Daney Cc: "linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org" , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Takashi Iwai , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Mark Brown , Tabi Timur-B04825 , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Jaroslav Kysela , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Liam Girdwood List-Id: devicetree@vger.kernel.org Cool, thanks. g. On Tue, May 22, 2012 at 4:49 PM, David Daney wrote: > On 05/22/2012 01:09 PM, Grant Likely wrote: >> >> On Tue, May 22, 2012 at 1:45 PM, David Daney >> =A0wrote: >>> >>> On 05/19/2012 11:08 PM, Grant Likely wrote: >>>> >>>> >>>> On Sat, 19 May 2012 23:54:36 -0600, Grant >>>> Likely =A0 =A0wrote: >>>>> >>>>> >>>>> On Fri, 11 May 2012 15:05:21 -0700, David Daney >>>>> =A0wrote: >>>>>> >>>>>> >>>>>> From: David Daney >>>>>> >>>>>> When generating MODALIASes, it is convenient to add things like "spi= :" >>>>>> or "i2c:" to the front of the strings. =A0This allows the standard >>>>>> modprobe to find the right driver when automatically populating bus >>>>>> children from the device tree structure. >>>>>> >>>>>> Add a prefix parameter, and adjust callers. =A0For >>>>>> of_register_spi_devices() use the "spi:" prefix. >>>>>> >>>>>> Signed-off-by: David Daney >>>>> >>>>> >>>>> >>>>> Applied, thanks. =A0Some notes below... >>>> >>>> >>>> >>>> Wait... why is this necessary? >>> >>> >>> >>> Because in of_register_spi_devices() in of_spi.c, you do: >>> >>> =A0 =A0 =A0 =A0request_module(spi->modalias); >>> >>> The string passed to request_module() must have the "spi:" prefix. >> >> >> How about modifying the call to request_module() to include the prefix >> also? =A0I think that would be a simpler change overall. =A0Would that >> work? > > > It seems to. =A0I just sent such a patch in a new thread. > > David Daney -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ---------------------------------------------------------------------------= --- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and = threat landscape has changed and how IT managers can respond. Discussions = will include endpoint security, mobile security and the latest in malware = threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/