From: Grant Likely <grant.likely@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] dtc: Update generated files to output from Bison 2.5
Date: Thu, 13 Jun 2013 23:24:55 +0100 [thread overview]
Message-ID: <CACxGe6tWx_GDYfZqKB-wN14jva51=SAdogjGkv2CicSJNUgNDw@mail.gmail.com> (raw)
In-Reply-To: <51BA42C8.60900@wwwdotorg.org>
On Thu, Jun 13, 2013 at 11:08 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 06/13/2013 03:48 PM, Grant Likely wrote:
>> This patch merely updates the generated dtc parser and lexer files to
>> the output generated by Bison 2.5. The previous versions were generated
>> from version 2.4.1. The only reason for this commit is to minimize the
>> diff on the next commit which fixes a bug in the DTC #line directive
>> parsing. Otherwise the Bison changes would be intermingled with the
>> functional changes.
>
> Do you actually need this patch? It should make no functional
> difference, and patch 2/2 only affects the lexer, not the parser, so
> wouldn't have these changes mingled in.
>
> But I suppose I'm not objecting.
I wasn't going to change one without the other. I rebuilt all of dtc
based on the version of dtc currently in the kernel and committed the
result. I'm not experienced enough with bison to try and hand select
the changes that do and do not go in.
g.
next prev parent reply other threads:[~2013-06-13 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 21:48 [PATCH 0/2] dtc: Fix #line directive bug Grant Likely
2013-06-13 21:48 ` [PATCH 1/2] dtc: Update generated files to output from Bison 2.5 Grant Likely
2013-06-13 22:08 ` Stephen Warren
2013-06-13 22:24 ` Grant Likely [this message]
[not found] ` <1371160133-10104-1-git-send-email-grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-13 21:48 ` [PATCH 2/2] dtc: ensure #line directives don't consume data from the next line Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACxGe6tWx_GDYfZqKB-wN14jva51=SAdogjGkv2CicSJNUgNDw@mail.gmail.com' \
--to=grant.likely@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).