devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v6 00/12] Add ACPI _DSD and unified device properties support
@ 2014-10-21 21:08 Rafael J. Wysocki
  2014-10-21 21:09 ` [PATCH v6 01/12] ACPI: Add support for device specific properties Rafael J. Wysocki
                   ` (12 more replies)
  0 siblings, 13 replies; 29+ messages in thread
From: Rafael J. Wysocki @ 2014-10-21 21:08 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: ACPI Devel Maling List, Greg Kroah-Hartman, Darren Hart,
	Mika Westerberg, Aaron Lu, Grant Likely, Arnd Bergmann,
	devicetree, Linus Walleij, Alexandre Courbot, Dmitry Torokhov,
	Bryan Wu

Hi Everyone,

This is version 6 of the unified device properties interface patchset.

The original cover letter from Mika is here:

http://marc.info/?l=devicetree&m=141087052200600&w=4

and my cover letters for previous iterations are at:

http://marc.info/?l=linux-acpi&m=141212903816560&w=4
http://marc.info/?l=linux-kernel&m=141354745011569&w=4

There are a few changes with respect to v5 and the affected patches are
[02-03/12] and [09-12/12].  The remaining ones have not been modified.

Most importantly, requesting the first element of a list (package) property
from _DSD is now equivalent to accessing a single-value property of the
same type, so device_property_read_u8(dev, pname, val) will now be equivalent
to device_property_read_u8_array(dev, pname, val, 1), for example.
Consequently, this _DSD definition:

Name (_DSD, Package () {
    ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
    Package () {
        Package () {"blah", "A string"},
    }
})

can be used instead of

Name (_DSD, Package () {
    ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
    Package () {
        Package () {"blah", Package () {"A string"}},
    }
})

and the code will be able to retrieve the property value from the both of
them just fine.

This means, among other things, that accessors for single-value properties
can be implemented in terms of the analogous "array" property accessors
which allows the code size to be reduced somewhat.

Patches [02/12] and [09/12] have been modified to achieve that and patch
[03/12] have been modified accordingly for the "compatible" property in
_DSD to behave in an analogous way.  Additionally, the bodies of the
numerical property accessors in patches [02/12] and [09/12] are now
generated using macros (string property accessors have slightly different
rules and are simply open coded for that reason).

Patch [10/12] has been modified to drop function arguments that happened to
have the same values for both of the current users of those functions and
patches [11-12/12] have been modified to take that change into account.  If
the code in question needs to be made more complex in the future, there
should not be any problems with that.

Due to the nature of the changes I have retained all ACKs except for the
Grant's Reviewed-by on patch [03/12] (if that had been Acked-by, I would have
retained it too, but that didn't feel appropriate for the "reviewed by" thing
to me).  If any of you think that the ACKs are not applicable any more, please
let me know and I'll drop them.

Finally, many thanks to Mika for testing the series on MinnowBoard 1 and
MinnowBoard Max.  In case anybody else would like to test it, it is available
from the device-properties branch of the linux-pm.git tree:

git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git device-properties

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2014-11-04 21:29 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 21:08 [PATCH v6 00/12] Add ACPI _DSD and unified device properties support Rafael J. Wysocki
2014-10-21 21:09 ` [PATCH v6 01/12] ACPI: Add support for device specific properties Rafael J. Wysocki
2014-10-21 21:15 ` [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware Rafael J. Wysocki
2014-11-03 15:40   ` Grant Likely
2014-11-03 22:04     ` Rafael J. Wysocki
     [not found]       ` <3645687.BsyGDrJDrU-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-11-04 17:01         ` Grant Likely
     [not found]           ` <CACxGe6uv0TmoZivL3ESw+oRW-OjqakLP4KBnDrwJXzQ2ku8ZLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-04 21:29             ` Rafael J. Wysocki
2014-11-04 15:51   ` Grant Likely
     [not found]     ` <20141104155112.6FC67C423D0-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-04 16:20       ` Rafael J. Wysocki
     [not found]   ` <2127128.VT1Iq03xz1-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-11-04 16:38     ` [Update][PATCH " Rafael J. Wysocki
2014-10-21 21:19 ` [PATCH v6 03/12] ACPI: Allow drivers to match using Device Tree compatible property Rafael J. Wysocki
2014-10-21 21:19 ` [PATCH v6 04/12] misc: at25: Make use of device property API Rafael J. Wysocki
2014-11-04 14:18   ` Grant Likely
     [not found]     ` <20141104141826.36F8AC408F6-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-04 14:38       ` Mika Westerberg
2014-11-04 15:04         ` Grant Likely
2014-11-04 16:19           ` Rafael J. Wysocki
     [not found]             ` <4645043.WOkgNMSUuO-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-11-04 16:07               ` Mika Westerberg
2014-10-21 21:20 ` [PATCH v6 05/12] gpio / ACPI: Add support for _DSD device properties Rafael J. Wysocki
2014-10-21 21:21 ` [PATCH v6 06/12] gpio: sch: Consolidate core and resume banks Rafael J. Wysocki
2014-10-21 21:21 ` [PATCH v6 07/12] leds: leds-gpio: Add support for GPIO descriptors Rafael J. Wysocki
2014-10-21 21:22 ` [PATCH v6 08/12] input: gpio_keys_polled: " Rafael J. Wysocki
2014-10-21 21:29 ` [PATCH v6 09/12] Driver core: Unified interface for firmware node properties Rafael J. Wysocki
2014-11-04 16:43   ` [Update][PATCH " Rafael J. Wysocki
2014-10-21 21:33 ` [PATCH v6 10/12] gpio: Support for unified device properties interface Rafael J. Wysocki
2014-10-21 21:35 ` [PATCH v6 11/12] leds: leds-gpio: Make use of device property API Rafael J. Wysocki
2014-10-21 21:37 ` [PATCH v6 12/12] input: gpio_keys_polled: " Rafael J. Wysocki
2014-10-24 22:10 ` [PATCH v6 00/12] Add ACPI _DSD and unified device properties support Rafael J. Wysocki
2014-11-04 15:49   ` Grant Likely
2014-11-04 16:20     ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).