Re: [PATCH] of: re-use kernel's kbasename()

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Wed, Oct 31, 2012 at 2:30 PM, Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>

Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Please merge through the same tree that adds the new kbasename function.

g.

> ---
>  drivers/of/fdt.c |   10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 91a375f..0ca0f9e 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -486,14 +486,8 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node,
>                 depth++;
>                 pathp = (char *)p;
>                 p = ALIGN(p + strlen(pathp) + 1, 4);
> -               if ((*pathp) == '/') {
> -                       char *lp, *np;
> -                       for (lp = NULL, np = pathp; *np; np++)
> -                               if ((*np) == '/')
> -                                       lp = np+1;
> -                       if (lp != NULL)
> -                               pathp = lp;
> -               }
> +               if (*pathp == '/')
> +                       pathp = kbasename(pathp);
>                 rc = it(p, pathp, depth, data);
>                 if (rc != 0)
>                         break;
> --
> 1.7.10.4
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.