From: Jagan Teki <jagannadh.teki@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Heiko Stuebner <heiko@sntech.de>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-rockchip@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board
Date: Fri, 1 Sep 2017 22:36:08 +0530 [thread overview]
Message-ID: <CAD6G_RSR35sX2x8xpdht0XUbnjeEBML9bxwCqtHYC7oM5fazEA@mail.gmail.com> (raw)
In-Reply-To: <20170831210421.l2zmpexisagoxdks@rob-hp-laptop>
On Fri, Sep 1, 2017 at 2:34 AM, Rob Herring <robh@kernel.org> wrote:
> On Sat, Aug 26, 2017 at 03:39:24PM +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>>
>> This patch adds initial support for rk3288 based
>> Vyasa board, which is made by Amarula Solutions.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> Changes for v2:
>> - Added entry in Documentation/devicetree/bindings/arm/rockchip.txt
>>
>> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
>> arch/arm/boot/dts/Makefile | 3 +-
>> arch/arm/boot/dts/rk3288-vyasa.dts | 312 +++++++++++++++++++++
>> 3 files changed, 318 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/boot/dts/rk3288-vyasa.dts
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> I assume the regulator node names are consistent with other platforms,
> but at some point please fix them to be lowercase and not use '_'. IOW,
> build the dtbs with "W=2" and fix the warnings.
Out-off these [1], only /i2c@ff650000 and /memory are related to this
dts and these are consistent across rk3288 dts node name, so there is
nothing that I can fix here. If not please let me know if you find
any.
[1] https://paste.ubuntu.com/25445917/
thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
next prev parent reply other threads:[~2017-09-01 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 10:09 [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board Jagan Teki
2017-08-31 21:04 ` Rob Herring
2017-09-01 17:06 ` Jagan Teki [this message]
[not found] ` <CAD6G_RSR35sX2x8xpdht0XUbnjeEBML9bxwCqtHYC7oM5fazEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-01 17:20 ` Heiko Stuebner
[not found] ` <1503742164-3926-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2017-09-09 11:55 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD6G_RSR35sX2x8xpdht0XUbnjeEBML9bxwCqtHYC7oM5fazEA@mail.gmail.com \
--to=jagannadh.teki@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).