From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DE5C433DF for ; Sun, 5 Jul 2020 09:01:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB24B20771 for ; Sun, 5 Jul 2020 09:01:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fF9zYQi0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbgGEJBP (ORCPT ); Sun, 5 Jul 2020 05:01:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726597AbgGEJBO (ORCPT ); Sun, 5 Jul 2020 05:01:14 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436B2C08C5DE for ; Sun, 5 Jul 2020 02:01:14 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so36019934wmi.3 for ; Sun, 05 Jul 2020 02:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=przTgcny48jd36+oUDZM5VqCUdMOADezAA8z959EYFc=; b=fF9zYQi0OpwzjVvrADGQzgm2O41ekp6ploUjNNPvEqx5jng5xwHlHbfYptRi64sPpg y9iYB7gdR12OKlD4m+vpzQ5HWVD/r2X/aXXkxecU8KXbkdyhQXG566LN+gYJJNhSfyS/ 0kCQ3Zc84FPQ3TKpJDQDW4mVezKPtKnTDxmNkz5FM55PWSYtAqq+DqYEmgLh2V4jfrz2 JdqbhWl/ZYq2OW8Rw/xe0vw0KzeTxr7oWAN7tLvKB0oXTNY2y+LPpugCEZoIKz7Kqeug BLRT93sRc2OPX/gEwNf1uRSW/pD/rDyhI4EEsmUjNRqk1kJ/8FPgzO0k1kNaBgIWS6kd 2VCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=przTgcny48jd36+oUDZM5VqCUdMOADezAA8z959EYFc=; b=YZJFFulX57z9+YAMg0PtyjkisJJS0u7ZxwGwEuktfqLrNDeKjEvhD60M9lbWLO/huH PgJFTRX9gvsZbm/Vlahx4nHwrvG2MPv9WOipih4XHBobmBT7iHh+qr7T0iok+LHs9WHA Qveaz2XgT1+34FcGnBTWzJMqFW8fCxMbiQGKdfELjKFCPjGlIoZ2ov32cvCMVnKr38Nt lI+Edp3V0e09UJOADagsRdR8MpnqngxasqPpCLOi7eMgk9oU/MriBQJl7qjCEgU2S55e nAFyuS1zCRe6agTdmHGZ9JV78dVxHnVB2lDddD6iiF4aJdJk55Ya0GUdCkrqGDxFSR7/ t5ng== X-Gm-Message-State: AOAM532dT4UMkn59zb6ceVP7ID3fmEDAOPUZ4EJrdEC7ZdIDpIwDw0jG lqlbRHnVYawUYSJbCEB51XlsJUwmqHOC/Mu2vsrlNQ== X-Google-Smtp-Source: ABdhPJynH7yvwhYRqBjAT6B2crW294fuviv7qzPIHYptEd/zWVZKZnYRZ8CfSV3sTGh2SAjw5YIHx6qxn3RjWJpV3bo= X-Received: by 2002:a7b:cf18:: with SMTP id l24mr17960976wmg.116.1593939672936; Sun, 05 Jul 2020 02:01:12 -0700 (PDT) MIME-Version: 1.0 References: <20200701013320.130441-1-drew@beagleboard.org> In-Reply-To: <20200701013320.130441-1-drew@beagleboard.org> From: Haojian Zhuang Date: Sun, 5 Jul 2020 17:01:02 +0800 Message-ID: Subject: Re: [PATCH v4 0/2] pinctrl: single: support #pinctrl-cells = 2 To: Drew Fustini Cc: Tony Lindgren , Rob Herring , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , devicetree@vger.kernel.org, bcousson@baylibre.com, Jason Kridner , Robert Nelson Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 1 Jul 2020 at 09:33, Drew Fustini wrote: > > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to > get the value to store in the register. > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > omap.h is modified to keep pin conf and pin mux values separate. > > change log: > - v4: squash patches 2 and 3 together so that git biesct will not result > in a boot failure > > - v3: change order of patches to make sure the pinctrl-single.c patch > does not break anything without the dts patches > > - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a > compile error in dtc. I had added it per suggestion from checkpatch > about having parentheses around complex values. > > Drew Fustini (2): > pinctrl: single: parse #pinctrl-cells = 2 > ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 > > arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- > drivers/pinctrl/pinctrl-single.c | 11 +++++++++-- > include/dt-bindings/pinctrl/omap.h | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) > > -- > 2.25.1 > Acked-by: Haojian Zhuang