From: Doug Anderson <dianders@chromium.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
"Joseph S. Barrera III" <joebar@chromium.org>,
Gustave Monce <gustave.monce@outlook.com>,
Vinod Koul <vkoul@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] arm64: dts: qcom: sc7180-trogdor-pazquel: correct trackpad supply
Date: Mon, 13 Mar 2023 07:37:51 -0700 [thread overview]
Message-ID: <CAD=FV=Uhpc5idOzPt5Oknzng8qaTFh4Fsibs1hXFfZRsKn+9cA@mail.gmail.com> (raw)
In-Reply-To: <20230312183622.460488-4-krzysztof.kozlowski@linaro.org>
Hi,
On Sun, Mar 12, 2023 at 11:36 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other
> boards which use elan,ekth3000 with valid VCC:
>
> sc7180-trogdor-pazquel360-lte.dtb: trackpad@15: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: fb69f6adaf88 ("arm64: dts: qcom: sc7180: Add pazquel dts files")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi
> index d06cc4ea3375..8823edbb4d6e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi
> @@ -39,7 +39,7 @@ trackpad: trackpad@15 {
> interrupt-parent = <&tlmm>;
> interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
>
> - vcc-supply = <&pp3300_fp_tp>;
> + vdd-supply = <&pp3300_fp_tp>;
Luckily it didn't matter since this regulator is always on, but good
to have things described properly.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2023-03-13 14:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 18:36 [PATCH 1/8] arm64: dts: qcom: sda660-inforce: correct key node name Krzysztof Kozlowski
2023-03-12 18:36 ` [PATCH 2/8] arm64: dts: qcom: sc7280-herobrine-villager: correct trackpad supply Krzysztof Kozlowski
2023-03-13 8:48 ` Konrad Dybcio
2023-03-13 14:37 ` Doug Anderson
2023-03-13 18:09 ` Stephen Boyd
2023-03-12 18:36 ` [PATCH 3/8] arm64: dts: qcom: sc7180-trogdor-lazor: " Krzysztof Kozlowski
2023-03-13 8:49 ` Konrad Dybcio
2023-03-13 14:37 ` Doug Anderson
2023-03-13 18:09 ` Stephen Boyd
2023-03-12 18:36 ` [PATCH 4/8] arm64: dts: qcom: sc7180-trogdor-pazquel: " Krzysztof Kozlowski
2023-03-13 8:49 ` Konrad Dybcio
2023-03-13 14:37 ` Doug Anderson [this message]
2023-03-13 18:10 ` Stephen Boyd
2023-03-12 18:36 ` [PATCH 5/8] arm64: dts: qcom: msm8998-oneplus-cheeseburger: revert "fix backlight pin function" Krzysztof Kozlowski
2023-03-13 8:50 ` Konrad Dybcio
2023-03-12 18:36 ` [PATCH 6/8] arm64: dts: qcom: msm8994-kitakami: drop unit address from PMI8994 regulator Krzysztof Kozlowski
2023-03-13 8:53 ` Konrad Dybcio
2023-03-12 18:36 ` [PATCH 7/8] arm64: dts: qcom: msm8994-msft-lumia-octagon: " Krzysztof Kozlowski
2023-03-13 8:53 ` Konrad Dybcio
2023-03-12 18:36 ` [PATCH 8/8] arm64: dts: qcom: apq8096-db820c: " Krzysztof Kozlowski
2023-03-13 8:54 ` Konrad Dybcio
2023-03-12 18:38 ` [PATCH 1/8] arm64: dts: qcom: sda660-inforce: correct key node name Krzysztof Kozlowski
2023-03-13 8:47 ` Konrad Dybcio
2023-04-05 4:09 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Uhpc5idOzPt5Oknzng8qaTFh4Fsibs1hXFfZRsKn+9cA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustave.monce@outlook.com \
--cc=joebar@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).