From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A8DDC433EF for ; Mon, 1 Nov 2021 17:09:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F1BE611C8 for ; Mon, 1 Nov 2021 17:09:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232422AbhKARMb (ORCPT ); Mon, 1 Nov 2021 13:12:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231303AbhKARMb (ORCPT ); Mon, 1 Nov 2021 13:12:31 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C11C061764 for ; Mon, 1 Nov 2021 10:09:57 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id l7so19180921iln.8 for ; Mon, 01 Nov 2021 10:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=06y9LPENRB0cLa2ThUDGeREBwekAGDiXTO1jiEpj+M4=; b=Ou+OTrGFXXKsJ9P9LaK1MrW6DAKCtk5CLB8nIgVQUE2E0dPzIuDrpuTBvz/C+UTFnE NhxiNgmXO2NePy77yjAzHbU/QZCl7AOkJhGVNV2TKL09T7uROpmiw4VA517zbrY6Wnvc JLuhkFSgtxjvlW9SrK+I0hOVg0I5k2Ggwtczk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=06y9LPENRB0cLa2ThUDGeREBwekAGDiXTO1jiEpj+M4=; b=CYMXPrkSXZx5g7U8CDJhB2llMoMmFmmURgGB2bE6V1ML7yy/XzN5UkCmX+sLKUzXYK nf0al+/sqf0WmC7BBiGcjpczQdshm752cVNa5KxQpiTxd/QcPHu3IFAKYk2AyUKZlCU7 bk2WcvYkKKGYmQainV9PjzZcidlszxxjqTNyJGk7AQT+XlyxgYjtbz1wPdP5SdWSZYaw AtUGEDT+D7ffQwJhFzMC5O1UHQWjrtvMmPYS6b1F1atDEI/S/34WGPPUdtE7kharuMDM ioaNjKtK2gzhxFWu1LxsEIoMiw/bcJ0fPYlcjivp6+WKskiE5fooMFBF+D2OakqPdwNd AH1A== X-Gm-Message-State: AOAM532Rp+By312n4KcAywA/6sVKR7pOW9jBioNdpGtxk8xl1IRuDo4I 3EhVeXAuEMiLQ21FPyZ4yd21FWIDJkG/zQ== X-Google-Smtp-Source: ABdhPJzFFTYIqcij2uKsfgQazkqHFgUtCoopbhlks5KW1HM//GeFvOTJG8ktm4xhRdh9xLI/loVTFA== X-Received: by 2002:a05:6e02:1749:: with SMTP id y9mr14981095ill.232.1635786596832; Mon, 01 Nov 2021 10:09:56 -0700 (PDT) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com. [209.85.166.182]) by smtp.gmail.com with ESMTPSA id b4sm8031543iot.45.2021.11.01.10.09.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 10:09:56 -0700 (PDT) Received: by mail-il1-f182.google.com with SMTP id l8so1343885ilv.3 for ; Mon, 01 Nov 2021 10:09:55 -0700 (PDT) X-Received: by 2002:a05:6e02:15cb:: with SMTP id q11mr21224592ilu.180.1635786595591; Mon, 01 Nov 2021 10:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20211029152647.v3.1.Ie17e51ad3eb91d72826ce651ca2786534a360210@changeid> <20211029152647.v3.3.Ie56f55924f5c7706fe3194e710bbef6fdb8b5bc6@changeid> In-Reply-To: <20211029152647.v3.3.Ie56f55924f5c7706fe3194e710bbef6fdb8b5bc6@changeid> From: Doug Anderson Date: Mon, 1 Nov 2021 10:09:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/4] arm64: dts: sc7180: Support Lazor/Limozeen rev9 To: Philip Chen Cc: LKML , Stephen Boyd , Andy Gross , Bjorn Andersson , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Fri, Oct 29, 2021 at 3:27 PM Philip Chen wrote: > > Support Lazor/Limozeen rev9 board where Parade ps8640 is added as the > second source edp bridge. > > To support different edp bridge chips in different board revisions, > now we move the #incldue line of the edp bridge dts fragment (e.g. > sc7180-trogdor-ti-sn65dsi86.dtsi) from "sc7180-trogdor-lazor.dtsi" to > per-board-rev dts files. > > Since the edp bridge dts fragment overrides 'dsi0_out', which is > defined in "sc7180.dtsi", move the #incldue line of "sc7180.dtsi" from > "sc7180-trogdor-lazor.dtsi" to per-board-rev dts files too, before > the #include line of the edp bridge dts fragment. > > Signed-off-by: Philip Chen > Reviewed-by: Stephen Boyd > --- > Retroactively edit the v2 change log slightly > > (no changes since v2) > > Changes in v2: > - Explain why "sc7180.dtsi" is moved out of "sc7180-trogdor-lazor.dtsi" > in the commit message. > - In limozeen (nots) r5 dts, replace "google,rev5-sku5" with > "google,lazor-rev5-sku5" and sort it > - In limozeen (nots) r9 dts, drop the support for "sku5". > - In limozeen r4 dts, remove the redundant "google,lazor-rev6-sku4" and > add "google,lazor-rev7-sku4". > - Do not add panel compatible in -r9 dts files. > - Move the #include line of gpio.h from sc7180.dtsi to the bridge dts > fragments, and factor out this change to patch 1/3. > > arch/arm64/boot/dts/qcom/Makefile | 9 +++- > .../sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +- > .../sc7180-trogdor-lazor-limozeen-nots-r5.dts | 31 +++++++++++++ > ...sc7180-trogdor-lazor-limozeen-nots-r9.dts} | 8 ++-- > .../qcom/sc7180-trogdor-lazor-limozeen-r4.dts | 46 +++++++++++++++++++ > ...s => sc7180-trogdor-lazor-limozeen-r9.dts} | 6 ++- > .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 2 + > .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 2 + > .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 9 +++- > .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 9 +++- > .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 8 +++- > .../dts/qcom/sc7180-trogdor-lazor-r9-kb.dts | 22 +++++++++ > .../dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 30 ++++++++++++ > .../boot/dts/qcom/sc7180-trogdor-lazor-r9.dts | 18 ++++++++ > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 3 -- > 15 files changed, 188 insertions(+), 17 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts > rename arch/arm64/boot/dts/qcom/{sc7180-trogdor-lazor-limozeen-nots.dts => sc7180-trogdor-lazor-limozeen-nots-r9.dts} (60%) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dts > rename arch/arm64/boot/dts/qcom/{sc7180-trogdor-lazor-limozeen.dts => sc7180-trogdor-lazor-limozeen-r9.dts} (82%) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dts Reviewed-by: Douglas Anderson