From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH 3/6] ARM: dts: Create cros-tps65090 fragment Date: Tue, 12 Aug 2014 10:26:45 -0700 Message-ID: References: <1407861868-20097-1-git-send-email-javier.martinez@collabora.co.uk> <1407861868-20097-4-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1407861868-20097-4-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-samsung-soc-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Kukjin Kim , Olof Johansson , Yuvaraj Kumar C D , Mark Brown , linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org Javier, On Tue, Aug 12, 2014 at 9:44 AM, Javier Martinez Canillas wrote: > The tps65090 PMU is a component used in many ChromeOS devices > so instead of having the same device tree definitions in many > files, create a .dtsi fragment that can be included in DTS. > > This fragment is based on the DT definitions for Peach boards. > > Signed-off-by: Javier Martinez Canillas > --- > arch/arm/boot/dts/cros-tps65090.dtsi | 81 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 arch/arm/boot/dts/cros-tps65090.dtsi I'd probably skip this patch (just have duplication in pit vs. pi), or make it "peach" specific (like exynos-peach-tps65090.dtsi?). This is really board-specific info and trying to guess what the various FETs are going to be for for all peach variants doesn't seem great. -Doug