From: "Michał Grzelak" <mig@semihalf.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
andrew@lunn.ch, chris.packham@alliedtelesis.co.nz,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
upstream@semihalf.com, mw@semihalf.com, mchl.grzlk@gmail.com
Subject: Re: [PATCH v3] dt-bindings: net: marvell,orion-mdio: Fix examples
Date: Thu, 29 Dec 2022 15:51:10 +0100 [thread overview]
Message-ID: <CADcojVOt+pWSZkVdOSE15HmdfFSZWNDUkEA1hNvn62vGAYjFsg@mail.gmail.com> (raw)
In-Reply-To: <8e4ec6b0-63cf-c086-c00e-5b4e8a2b2d25@linaro.org>
Hi Krzysztof,
On Thu, Dec 29, 2022 at 3:30 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 29/12/2022 15:22, Michał Grzelak wrote:
> > As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f
> > ("dt-bindings: net: orion-mdio: Convert to JSON schema") if
> > 'interrupts' property is present, width of 'reg' should be 0x84.
> > Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add
> > constraints checking whether 'interrupts' property is present
> > and validate it against fixed values in reg.
> >
> > Signed-off-by: Michał Grzelak <mig@semihalf.com>
>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
Deletion of tag wasn't on purpose, it was done by accident. Would you
like me to resend the patch with it being added, or leave it as is?
Best regards,
Michał
next prev parent reply other threads:[~2022-12-29 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 14:22 [PATCH v3] dt-bindings: net: marvell,orion-mdio: Fix examples Michał Grzelak
2022-12-29 14:30 ` Krzysztof Kozlowski
2022-12-29 14:51 ` Michał Grzelak [this message]
2022-12-29 15:00 ` Krzysztof Kozlowski
2023-01-01 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADcojVOt+pWSZkVdOSE15HmdfFSZWNDUkEA1hNvn62vGAYjFsg@mail.gmail.com \
--to=mig@semihalf.com \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchl.grzlk@gmail.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).