* [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 @ 2025-06-20 15:29 Kamal Wadhwa 2025-06-23 11:23 ` Konrad Dybcio 2025-08-24 2:55 ` Bjorn Andersson 0 siblings, 2 replies; 5+ messages in thread From: Kamal Wadhwa @ 2025-06-20 15:29 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, Neil Armstrong, Kamal Wadhwa Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently configured at 3304000uV in different sm8550 board files. However this is not a valid voltage value for 'pmic5_pldo502ln' type voltage regulators. Check below the max value(3200mV) in the regulator summary for min/max used as 2800mV/3304mV in DT:- logs: [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV regulator summary: regulator use open bypass opmode voltage current min max --------------------------------------------------------------------- .. vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV .. Correct the min/max value to 3200000uV, as that is the closest valid value to 3.3V and Hardware team has also confirmed that its good to support the consumers(camera sensors) of this regulator. Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> --- Changes from v1: - Updated voltage settings with min = max = 3.2v, which is the closest valid value to 3.3v, as suggested by Bjorn Anderrson. - Reverted the phandle name change(name unchanged now) --- arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts index 29bc1ddfc7b25f203c9f3b530610e45c44ae4fb2..4d13d9bdd53194d655957f147f9d78cb4cc9abbd 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts @@ -859,8 +859,8 @@ vreg_l5n_1p8: ldo5 { vreg_l6n_3p3: ldo6 { regulator-name = "vreg_l6n_3p3"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-min-microvolt = <3200000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index 5648ab60ba4c4bfaf5baa289969898277ee57cef..e207bb38d82cf7a0ab896e76d5a184a44b4a3f71 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -626,8 +626,8 @@ vreg_l5n_1p8: ldo5 { vreg_l6n_3p3: ldo6 { regulator-name = "vreg_l6n_3p3"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-min-microvolt = <3200000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts index 3a6cb279130489168f8d20a6e27808647debdb41..5c6f73291da185d39d8bd7cf505727d87271bf30 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts @@ -702,8 +702,8 @@ vreg_l5n_1p8: ldo5 { vreg_l6n_3p3: ldo6 { regulator-name = "vreg_l6n_3p3"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-min-microvolt = <3200000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts index 7d29a57a2b540708fa88fb59e821406f400a3174..b4ef40ae2cd956d2c0a1e46d6428aaa6e5d9c4ee 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts @@ -487,8 +487,8 @@ vreg_l5n_1p8: ldo5 { vreg_l6n_3p3: ldo6 { regulator-name = "vreg_l6n_3p3"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-min-microvolt = <3200000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; --- base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc change-id: 20250620-sm8550-correct-vreg_l6n_3p3-vol-a1606e568154 Best regards, -- Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 2025-06-20 15:29 [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 Kamal Wadhwa @ 2025-06-23 11:23 ` Konrad Dybcio 2025-06-26 11:39 ` Kamal Wadhwa 2025-08-24 2:55 ` Bjorn Andersson 1 sibling, 1 reply; 5+ messages in thread From: Konrad Dybcio @ 2025-06-23 11:23 UTC (permalink / raw) To: Kamal Wadhwa, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, Neil Armstrong On 6/20/25 5:29 PM, Kamal Wadhwa wrote: > Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently > configured at 3304000uV in different sm8550 board files. However this > is not a valid voltage value for 'pmic5_pldo502ln' type voltage > regulators. > > Check below the max value(3200mV) in the regulator summary for min/max > used as 2800mV/3304mV in DT:- > > logs: > > [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV > > regulator summary: > > regulator use open bypass opmode voltage current min max > --------------------------------------------------------------------- > .. > vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV > .. > > Correct the min/max value to 3200000uV, as that is the closest valid > value to 3.3V and Hardware team has also confirmed that its good to > support the consumers(camera sensors) of this regulator. > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> > --- FWIW it seems like 3.312v (which is slightly above the previous value) is also supported: static const struct rpmh_vreg_hw_data pmic5_pldo502ln = { .regulator_type = VRM, .ops = &rpmh_regulator_vrm_ops, .voltage_ranges = (struct linear_range[]) { REGULATOR_LINEAR_RANGE(1800000, 0, 2, 200000), REGULATOR_LINEAR_RANGE(2608000, 3, 28, 16000), REGULATOR_LINEAR_RANGE(3104000, 29, 30, 96000), REGULATOR_LINEAR_RANGE(3312000, 31, 31, 0), }, .n_linear_ranges = 4, .n_voltages = 32, .pmic_mode_map = pmic_mode_map_pmic5_ldo_hpm, .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, }; but if the hw folks say we can do with the lower value, it's probably even better Konrad ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 2025-06-23 11:23 ` Konrad Dybcio @ 2025-06-26 11:39 ` Kamal Wadhwa 2025-06-26 14:14 ` Konrad Dybcio 0 siblings, 1 reply; 5+ messages in thread From: Kamal Wadhwa @ 2025-06-26 11:39 UTC (permalink / raw) To: Konrad Dybcio Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, Neil Armstrong Hi Konrad, On Mon, Jun 23, 2025 at 4:53 PM Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > > On 6/20/25 5:29 PM, Kamal Wadhwa wrote: > > Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently > > configured at 3304000uV in different sm8550 board files. However this > > is not a valid voltage value for 'pmic5_pldo502ln' type voltage > > regulators. > > > > Check below the max value(3200mV) in the regulator summary for min/max > > used as 2800mV/3304mV in DT:- > > > > logs: > > > > [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV > > > > regulator summary: > > > > regulator use open bypass opmode voltage current min max > > --------------------------------------------------------------------- > > .. > > vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV > > .. > > > > Correct the min/max value to 3200000uV, as that is the closest valid > > value to 3.3V and Hardware team has also confirmed that its good to > > support the consumers(camera sensors) of this regulator. > > > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> > > --- > > FWIW it seems like 3.312v (which is slightly above the previous > value) is also supported: > > static const struct rpmh_vreg_hw_data pmic5_pldo502ln = { > .regulator_type = VRM, > .ops = &rpmh_regulator_vrm_ops, > .voltage_ranges = (struct linear_range[]) { > REGULATOR_LINEAR_RANGE(1800000, 0, 2, 200000), > REGULATOR_LINEAR_RANGE(2608000, 3, 28, 16000), > REGULATOR_LINEAR_RANGE(3104000, 29, 30, 96000), > REGULATOR_LINEAR_RANGE(3312000, 31, 31, 0), > }, > .n_linear_ranges = 4, > .n_voltages = 32, > .pmic_mode_map = pmic_mode_map_pmic5_ldo_hpm, > .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, > }; Yes, originally I was planning to share the change for 3304mV -> 3312mV. However, while testing, I realized that I would also need changes in firmware( to allow for a 3312mV max limit). so during internal discussion it was clarified that all the consumers on L6N can work fine with 3.2v. > > but if the hw folks say we can do with the lower value, it's probably > even better Yes. Thanks for affirming. Thanks, Kamal > > Konrad ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 2025-06-26 11:39 ` Kamal Wadhwa @ 2025-06-26 14:14 ` Konrad Dybcio 0 siblings, 0 replies; 5+ messages in thread From: Konrad Dybcio @ 2025-06-26 14:14 UTC (permalink / raw) To: Kamal Wadhwa Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, Neil Armstrong On 6/26/25 1:39 PM, Kamal Wadhwa wrote: > Hi Konrad, > > On Mon, Jun 23, 2025 at 4:53 PM Konrad Dybcio > <konrad.dybcio@oss.qualcomm.com> wrote: >> >> On 6/20/25 5:29 PM, Kamal Wadhwa wrote: >>> Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently >>> configured at 3304000uV in different sm8550 board files. However this >>> is not a valid voltage value for 'pmic5_pldo502ln' type voltage >>> regulators. >>> >>> Check below the max value(3200mV) in the regulator summary for min/max >>> used as 2800mV/3304mV in DT:- >>> >>> logs: >>> >>> [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV >>> >>> regulator summary: >>> >>> regulator use open bypass opmode voltage current min max >>> --------------------------------------------------------------------- >>> .. >>> vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV >>> .. >>> >>> Correct the min/max value to 3200000uV, as that is the closest valid >>> value to 3.3V and Hardware team has also confirmed that its good to >>> support the consumers(camera sensors) of this regulator. >>> >>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >>> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> >>> --- >> >> FWIW it seems like 3.312v (which is slightly above the previous >> value) is also supported: >> >> static const struct rpmh_vreg_hw_data pmic5_pldo502ln = { >> .regulator_type = VRM, >> .ops = &rpmh_regulator_vrm_ops, >> .voltage_ranges = (struct linear_range[]) { >> REGULATOR_LINEAR_RANGE(1800000, 0, 2, 200000), >> REGULATOR_LINEAR_RANGE(2608000, 3, 28, 16000), >> REGULATOR_LINEAR_RANGE(3104000, 29, 30, 96000), >> REGULATOR_LINEAR_RANGE(3312000, 31, 31, 0), >> }, >> .n_linear_ranges = 4, >> .n_voltages = 32, >> .pmic_mode_map = pmic_mode_map_pmic5_ldo_hpm, >> .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, >> }; > > Yes, originally I was planning to share the change for 3304mV -> 3312mV. > However, while testing, I realized that I would also need changes in > firmware( to allow for a 3312mV max limit). so during internal discussion > it was clarified that all the consumers on L6N can work fine with 3.2v. > > >> >> but if the hw folks say we can do with the lower value, it's probably >> even better > > Yes. Thanks for affirming. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 2025-06-20 15:29 [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 Kamal Wadhwa 2025-06-23 11:23 ` Konrad Dybcio @ 2025-08-24 2:55 ` Bjorn Andersson 1 sibling, 0 replies; 5+ messages in thread From: Bjorn Andersson @ 2025-08-24 2:55 UTC (permalink / raw) To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kamal Wadhwa Cc: linux-arm-msm, devicetree, linux-kernel, Neil Armstrong On Fri, 20 Jun 2025 20:59:57 +0530, Kamal Wadhwa wrote: > Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently > configured at 3304000uV in different sm8550 board files. However this > is not a valid voltage value for 'pmic5_pldo502ln' type voltage > regulators. > > Check below the max value(3200mV) in the regulator summary for min/max > used as 2800mV/3304mV in DT:- > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 commit: 40f7b64fac9d7d37b8db750909321fa2b0b7eda3 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-24 2:56 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-20 15:29 [PATCH v2] arm64: dts: qcom: sm8550: Correct the min/max voltages for vreg_l6n_3p3 Kamal Wadhwa 2025-06-23 11:23 ` Konrad Dybcio 2025-06-26 11:39 ` Kamal Wadhwa 2025-06-26 14:14 ` Konrad Dybcio 2025-08-24 2:55 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).