From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06BD21F929 for ; Wed, 11 Oct 2023 14:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="del6lvyz" Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67C3090 for ; Wed, 11 Oct 2023 07:43:24 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-d8168d08bebso7281613276.0 for ; Wed, 11 Oct 2023 07:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697035403; x=1697640203; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QHSGgNwplrQByUQEFDMoiW6T88xkz7+Z7CzZX4tel1c=; b=del6lvyz8L/ympiDcQdKBYdjBpFmPkmZ7Hr6GrQOkREWEDZcGYfYb4WMWOZLH2TMts o6WSTmSS2ny1c1H8OSRu1fyqeJdqcYrklcELEuMoEC/sPc3oTqdvu0GX+GckmWgNEgez 3pyiWkpYVMugu6DSqC3J1iqh2se1SgoYzuspzkGnh7sY7z81mwf66lE/QrIisDhxRsvZ DLpLxRIFzTqKNMpCukYEsAJhnfZHF5ntiGCUmiSLQbWUpEKqxwlENPyS2GMU3P47Xick mXWSkcVyTq0b4ML0CCwo/ZZu8n4tBWcLA+dAjCL6ZVWDVQQIJz2rV2Skmm8kIQRzLCxO LWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697035403; x=1697640203; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QHSGgNwplrQByUQEFDMoiW6T88xkz7+Z7CzZX4tel1c=; b=VeRYnChRjQQ7f4C0QKbQqdu0n7XqiNtNfXWxUloCYOrqb154REz2v7gAe/nor5quad v3iYwgxbBkvyC5crKFRdGkY7A+ZaEIC5fUYj4Giev1QL29bbuWCEcxhq0uI3ju4qfZZU Q8m0fBEDxXXOEqWnmDaYs4GgqP/Ou3zdJZJhYiwDd23Ku0bQ9pkbIOkcWlVgTAERWZ1m /I2uHf6gzu2KZONF4IYXxUPSscPWLFxc7AORKo0a5xDUV5izeE2G9Gs02KJ+snpdaNCF v0qzGOE/cuSQXhCQIHirQb8Uz7d+ghYOt3lsaScS4AkCOaZay4JIWwoA7hUQekeO5o0X iWxQ== X-Gm-Message-State: AOJu0YzV3jJQxicwamdJh8xljce/JiwZZW06IWhnKxrtVdSCpTKNJMLB 8iZbnGe5O5dGmjpZCKqjmJ14LocpY/iV8Ks2gpMCQQ== X-Google-Smtp-Source: AGHT+IG6ejFYIQqSBlCuZeoLJFdvXD5HM2pcfGye3trv5p0ja9AYy6Vps/U8uovRHfUX5MkuYivucvBJhgbz9bJ3CCY= X-Received: by 2002:a25:5d1:0:b0:d9a:501e:95d7 with SMTP id 200-20020a2505d1000000b00d9a501e95d7mr4970434ybf.8.1697035403592; Wed, 11 Oct 2023 07:43:23 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231010224928.2296997-1-peter.griffin@linaro.org> <20231010224928.2296997-16-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Wed, 11 Oct 2023 15:43:12 +0100 Message-ID: Subject: Re: [PATCH v2 15/20] watchdog: s3c2410_wdt: Add support for Google tensor SoCs To: Guenter Roeck Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Guenter, Thanks for your review. On Wed, 11 Oct 2023 at 00:56, Guenter Roeck wrote: > > On Tue, Oct 10, 2023 at 11:49:23PM +0100, Peter Griffin wrote: > > This patch adds the compatibles and drvdata for the Google > > gs101 & gs201 SoCs found in Pixel 6 and Pixel 7 phones. Similar > > to Exynos850 it has two watchdog instances, one for each cluster > > and has some control bits in PMU registers. > > > > The watchdog IP found in gs101 SoCs also supports a few > > additional bits/features in the WTCON register which we add > > support for and an additional register detailed below. > > > > dbgack-mask - Enables masking WDT interrupt and reset request > > according to asserted DBGACK input > > > > windowed-mode - Enabled Windowed watchdog mode > > > > Windowed watchdog mode also has an additional register WTMINCNT. > > If windowed watchdog is enabled and you reload WTCNT when the > > value is greater than WTMINCNT, it prompts interrupt or reset > > request as if the watchdog time has expired. > > I am a bit lost with this one. The patch adds QUIRK_HAS_WTMINCNT_REG > but doesn't use it. It also adds S3C2410_WTMINCNT but does not use it > either. > > What is the point of doing that ? It is just confusing. Good spot, it seems I lost a few hunks from this patch at some point, sorry about that. I will update and send a v3. regards, Peter.