From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E7C1386B3 for ; Mon, 24 Jun 2024 11:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228513; cv=none; b=B44HuDeEsd53sRMY3BWtugO0TWEdBKFt0v+TO8c2PUT9twHxsu+LR6NN0RsNl26QIZtYYXT2eq19K76lVKoZ9xAO4eXB+PI4hnNKdAOSxKh6JCFEuLPLiPlGLyI705M7QosdR1YRCcPeG+FI2u/4YFpcGTDijBzBYCM0Xdvw4FU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228513; c=relaxed/simple; bh=NYND7VdilAAcK8UQ6tNb4wM6mWC/LRp6HLGpJAraXLA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=aaZpzKhQollFP70TF3gYS1IVwILqdAbwcPmR0oGBC7fiw+qVJHVE2+h+iLX6FATd9UtYZouNkGrUZzI8lS4jsj1xzwCPXyaid4hZGmUrlXAzHUhxregULO793BM913TQ9b+8dZAAc5LkO7oRS/Q9jQq88SZIk50dSRMhjlTu2fU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Skk7pb8B; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Skk7pb8B" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5c1adbcaad3so1883368eaf.1 for ; Mon, 24 Jun 2024 04:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719228510; x=1719833310; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QteiONYM0/7wKm8o/iZbfkWsRu+IEcJCYcDxA/UWpZM=; b=Skk7pb8B4pTG2wluyc+M3BEnjjfsc+cjoBKHYUgSt4mMKH8bSzkDEfLplA6wY7xiFv gyXyAmNkJqM+Lb1EUY8iXv2TyuKvwMPucVhZ6wnLKqg9/QXQICkHXfxdmThoXJziHjMd KhIrKs43ZDZEefLpo17/tzYlWXXbE7tU2P9pAusJMO1ElDxa6NIUiycheVX9zT6lVu+9 gw29awlOqAcBZ4wcMeNCR3ndK95g1lDWnidLW/EPguZrSZ3dTX8oJBJZWiV+hL3jv3o2 B5XVnfVVFkX3XisnDmr85HOkBWb5CubA0PjgbeODapqszdB6lHztFk6vhIqxZUkwl2sm qJeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719228510; x=1719833310; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QteiONYM0/7wKm8o/iZbfkWsRu+IEcJCYcDxA/UWpZM=; b=lYaD+1RYvUPhHZZOsJQOphLqRxon0nuUY62jNP6yv7efdDLWny+5wA/LYlyRbVXWqH g3gVFRU/lISv+TfCf//cV/vuf8faNTXPX6p+MnX6TLwEzbqDrjkgCmqDvjI5fdDmrIJq FXyEw8HBOlDt0lRm4qeZH8HfEcGEbIlIFT5/5IJCFY3hYyE/jYxh1J+GbJKbGpVOn+TO bjdsh1rGH96Jx9duY5ok2sCALtyw4+mobzuLCEa0zZIWl03nJ5rw500bsVwMaUHpm+xN RjHr2Jntn2CHEfB0nqPkNTINmNyED/Karky3LLuytZybTZnFxMDEEM++ndN6qKL4YLTs sYXw== X-Forwarded-Encrypted: i=1; AJvYcCUTAiLeDQ4o+Q8uKWGJTmGoStKfnuOCPrCJeHycOAju7JXr7eWLzpAWe2B4bGV7DUDCjA5QV5wubhhI855C352e61ibKS0WUuSNrw== X-Gm-Message-State: AOJu0YxEkTyi7EV0yn5PydQygAlWPDVZRhAcACL3aab1dUc23qtS+I2A jCzPj7CnBM5XDnlPQFAw1ie1UO72LqgxA1d65GZrlRIbzgdD+dUUo762LAfKHlZH6udR5Xx8cvB hL3XWpBsJi5P/SZMAB6//Id88RaVR+3/04d3YMQ== X-Google-Smtp-Source: AGHT+IFlNv2FZElqgVQlBk87lsFwbs9c65tZcdtCpO79u3aNcvuYkknMUcQr9mTDHrMDvpletr+cOs9nxhTCAnVSEb4= X-Received: by 2002:a05:6820:60f:b0:5c1:e83b:ee10 with SMTP id 006d021491bc7-5c1e83bef4amr2456768eaf.1.1719228509995; Mon, 24 Jun 2024 04:28:29 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> In-Reply-To: <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> From: Peter Griffin Date: Mon, 24 Jun 2024 12:28:18 +0100 Message-ID: Subject: Re: [PATCH v3 5/6] phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk To: =?UTF-8?Q?Andr=C3=A9_Draszik?= Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Will McVicker , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andr=C3=A9, On Mon, 17 Jun 2024 at 17:45, Andr=C3=A9 Draszik = wrote: > > Using the regulator_bulk APIs, the handling of power supplies becomes > much simpler. There is no need anymore to check if regulators have been > acquired or not, the bulk APIs will do all the work for us. We can also > drop the various handles to the individual power supplies in the driver > runtime data and instead simply treat them all as one thing. Error > cleanup also becomes much simpler. > > Converting to the regulator_bulk APIs also makes it easier to add > support for those SoCs that have additional power supplies for the PHY. > Google Tensor gs101 is one example of such a SoC. Otherwise we'd have > to add all additional supplies individually via individual calls to > regulator_get() and enable/disable handle them all individually, > including complicated error handling. That doesn't scale and clutters > the code. > > Just update the code to use the regulator_bulk APIs. > > Signed-off-by: Andr=C3=A9 Draszik > --- Reviewed-by: Peter Griffin and Tested-by: Peter Griffin Tested using my Pixel 6 pro device. USB comes up and it is possible to use adb from the host computer to the phone. regards, Peter [..]