From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F35E137C2E for ; Mon, 24 Jun 2024 11:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228040; cv=none; b=tsgoord+4Vv3YK8/QE68/cCXe/fzVb8zXp3MW0yiDRPegyWF9WI6RAOTVO52SJqyawZfvd3lOQSTw0zmdkUG74XUvGMYFxlcbRIJWkgmaO2hcvk4xyvcPNnuTOniIJZXtG1cphfZetOjI18BFIeEmVQiJfZnVg+/1zP5dRhJ/OQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228040; c=relaxed/simple; bh=8SljLriCQU/R9iZ5gWt9zSCnrJAdSlcr5Md1yQsHitk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=OsWrzM9ng/8+QeRJ2ZmidBf32uxJ0mJweK5blNlHACERKMcEWznJpp7/b97NAZUNEIQ2IiE2IHKKCMGlC3ctcl8CqdpVGOycVp2lrM0F8D7EJLfgof3rp5JTix9PurSMkH0h0x+EyOp90D6SNUujjlGqTOvkNrVNu7b+lL6Bd2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HmuiA2J2; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HmuiA2J2" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5c2011716a3so266334eaf.1 for ; Mon, 24 Jun 2024 04:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719228037; x=1719832837; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hiWe4k8FtBd5fLnyYS4pxEhg5OzBr8vUWEFs5mIbuS4=; b=HmuiA2J2rC+CpZ6U6KTdguUb92pH7DT52mE3U8EnDhUKPXpB49IFYd3c+oLszwXYBg w8X5wMXwZCjFsvwgS4z3BHXvgGPrjfk92jQCVTVqTkDE8+5MHThp4TI6Tj5KtrPPLzm8 GsDWLqIlxIzdXvAWzRq0iDGDE+lV7FDMldHSy4pzBnBdq9b/b2u9wRsMb9BM//CDlhjX UQmVsAzr/NJHb1inZCmDFLg3d5o98EFVFVaLE+B50Z/WjDLdE7vsh8HKDIXL0qlGuPg0 DFHWNSXElIibyfEhOT0gSMBg3br4W6qT9V2v4v6vFoH0AA6i/UtP0jqpBwTuCbX4rpU/ frMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719228037; x=1719832837; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hiWe4k8FtBd5fLnyYS4pxEhg5OzBr8vUWEFs5mIbuS4=; b=LaqoT4nJEaiTpcsxf2nMWE4b1DXUs1AwXtYfLLgsyCf4ODyQhLFskGnQ8UdRXCVcYF rLSkgvRSsVeGpDDCFNBux9ZpbQJDlWUMT4XMVjN70s2IXZCBYZvC5ZgcpkjAgRLYv709 HloEq8ihxPoEOIVtNKBl0liFFWGGK4HfD7IX/wqMgZuZuNGJClGaCx0RcOtpEUMDh4lh G8dv3QgT5jXSFtdA0raFSF2OwR6kA00UJJF8QRnmVmp4Yd9FxYRlz7JIAqzsDqxSsXm6 h/OhiUxVcgw9Y0FGXaFVZF6jrw6t8B+RPlkP2/5rcno0jrSQ+w1BraHHRPIiiGbG15aF hp6A== X-Forwarded-Encrypted: i=1; AJvYcCXLunQBukojHDfnsEIvy8udgfD7CGfBaNvs00JkkeJxYUSqbT6FOoKJzVbwZj4u5pX5kLI6+ZIEO5f4l2w2JwShgkvq1fYd51LATw== X-Gm-Message-State: AOJu0YwCJGjP+oXKBIBWyIC79R13UyEO6HH+k1nXyhSiNQHaFlvm4sFI EG958FuhtSJ1K1TeTl+aUR8EWT1VfACugQ51cRUNnwiRQtl4dntI8mghijH/bv84bALSpRspha1 Kd0INzAgTi0Od9Xc1ciOhSTzEEj8AOam81wvr3A== X-Google-Smtp-Source: AGHT+IHfldjpB99ZpNwFcajstPYz4MdvmrWm26sCR24wJ27onowRiUicbCtcbFxhvjwoR18exO9DD0r6k4/LILVcIj4= X-Received: by 2002:a05:6820:2b0d:b0:5c1:eee6:6ed5 with SMTP id 006d021491bc7-5c1eee66f99mr3951941eaf.2.1719228037550; Mon, 24 Jun 2024 04:20:37 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> <20240617-usb-phy-gs101-v3-2-b66de9ae7424@linaro.org> In-Reply-To: <20240617-usb-phy-gs101-v3-2-b66de9ae7424@linaro.org> From: Peter Griffin Date: Mon, 24 Jun 2024 12:20:26 +0100 Message-ID: Subject: Re: [PATCH v3 2/6] phy: exynos5-usbdrd: support isolating HS and SS ports independently To: =?UTF-8?Q?Andr=C3=A9_Draszik?= Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Will McVicker , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andr=C3=A9, On Mon, 17 Jun 2024 at 17:45, Andr=C3=A9 Draszik = wrote: > > Some versions of this IP have been integrated using separate PMU power > control registers for the HS and SS parts. One example is the Google > Tensor gs101 SoC. > > Such SoCs can now set pmu_offset_usbdrd0_phy_ss in their > exynos5_usbdrd_phy_drvdata for the SS phy to the appropriate value. > > The existing 'usbdrdphy' alias can not be used in this case because > that is meant for determining the correct PMU offset if multiple > distinct PHYs exist in the system (as opposed to one PHY with multiple > isolators). > > Signed-off-by: Andr=C3=A9 Draszik > > --- Reviewed-by: Peter Griffin and Tested-by: Peter Griffin Tested using my Pixel 6 pro device. USB comes up and it is possible to use adb from the host to the phone regards, Peter [..]