From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AF6614F96 for ; Thu, 12 Oct 2023 10:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HOM19Zed" Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D40D7B7 for ; Thu, 12 Oct 2023 03:57:08 -0700 (PDT) Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-d9a7a3e17d1so864171276.2 for ; Thu, 12 Oct 2023 03:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697108228; x=1697713028; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eXsH2wAbuu1LZ+xVuXFZUVdPOgCW2cpv03v3rr+MUKM=; b=HOM19ZedhaIEcq8oEbdJIjEKhWK8hLoy9tDKgnFBrrADp3LL9OO/pnIvaxGaGVbfHp ukltIpyLtM1V6X0x1UmtMGjWBRC+oGP2w8NMhxoC1S+8KnGzaZRHikSlBDMdDrWy3mBv faDsYYbutNkewVwQimrQZ8muEUUYovbv1NZtNmKS54J4JGbvHxIF3o5OD3u8gv5vEdth y0Yu2QxGYzcKEpAMqFjuWPB1HengGo1KU5GLw62NT60ZKTd3gJhuJ2aemT+L/QNSE2L/ +/H61H8hM7KXeCPZhO9slcADzaFm6nFz4N6HiVzdlGM8F91uQaTEf0hgZbti5MGGyIJL DjIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697108228; x=1697713028; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eXsH2wAbuu1LZ+xVuXFZUVdPOgCW2cpv03v3rr+MUKM=; b=wtQNFAC4CNcJne1vut1inWzj4wt9vZvZPSOzPDnbtvSHTFR6f0CBeHf0WcmG1FP3tC x+qMBKS+nNrV2qzWHjyLFRtpNqAdfqGMJYwHcih0q13vNeQEZz4rBVHrSFLKB2G8O214 H3i9SB8ned7qkH+iVAbL89VzcPy3CmTA/VhkWSt73AXMB4WnVFUxpfq2u3qYeRSdsapS SXrcPeCgBQxYAX9jhLJdpjhe48N+KMop3yB95hRGj0/e2RIAhrbJ8nJQH6Tk0loD0Ez4 eTpljtSiqsGxWY7NV2DKLgAqaQgnQO9yB1h3rIDbXktLsOqTY5EtfkqXDRLpNXNYEeWq cSdQ== X-Gm-Message-State: AOJu0Yzbg72hqZzOH4pQV49HGl2urckXgdAWgMAI5oGn0wo4WafN10Zg PrNf188kqQRmVDyjoHAIDspNHAXVGzVlIUk61IX9SQ== X-Google-Smtp-Source: AGHT+IHoONc3hJii7RYcVkxb1UvFrk39Aq1j5ObRTTPqLaWzUuSZjNk8uWTkxQSzrzNgSo8ZjFPFsI+716xNwL6U+X0= X-Received: by 2002:a25:d48:0:b0:d9a:4e29:6354 with SMTP id 69-20020a250d48000000b00d9a4e296354mr8267648ybn.39.1697108228053; Thu, 12 Oct 2023 03:57:08 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231011184823.443959-1-peter.griffin@linaro.org> <20231011184823.443959-5-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Thu, 12 Oct 2023 11:56:56 +0100 Message-ID: Subject: Re: [PATCH v3 04/20] dt-bindings: watchdog: Document Google gs101 & gs201 watchdog bindings To: Sam Protsenko Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Sam, Thanks for the review. On Wed, 11 Oct 2023 at 23:58, Sam Protsenko wr= ote: > > On Wed, Oct 11, 2023 at 1:49=E2=80=AFPM Peter Griffin wrote: > > > > Add the "google,gs101-wdt" and "google,gs201-wdt" compatibles to the > > dt-schema documentation. > > > > gs101 SoC has two CPU clusters and each cluster has its own dedicated > > watchdog timer (similar to exynos850 and exynosautov9 SoCs). > > > > These WDT instances are controlled using different bits in PMU > > registers. > > > > Signed-off-by: Peter Griffin > > --- > > .../devicetree/bindings/watchdog/samsung-wdt.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yam= l b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > > index 8fb6656ba0c2..67c8767f0499 100644 > > --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > > @@ -17,6 +17,8 @@ description: |+ > > properties: > > compatible: > > enum: > > + - google,gs101-wdt # for Google gs101 > > + - google,gs201-wdt # for Google gs201 > > - samsung,s3c2410-wdt # for S3C2410 > > - samsung,s3c6410-wdt # for S3C6410, S5PV210 a= nd Exynos4 > > - samsung,exynos5250-wdt # for Exynos5250 > > @@ -42,13 +44,13 @@ properties: > > samsung,cluster-index: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: > > - Index of CPU cluster on which watchdog is running (in case of Ex= ynos850) > > + Index of CPU cluster on which watchdog is running (in case of Ex= ynos850 or Google gsx01) > > Please stick to 80 characters per line when possible. Will fix in v4. Peter