From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072AFE571 for ; Tue, 7 Oct 2025 09:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759828185; cv=none; b=Za/hDvO4PX0RzccQjF5HKs0IdIucqg0i6sO48bZ9nuequVzwL0kJ5QfoRVqrsBmhdpRcVDpdtU77FDwJxjigQPrwdiiSHH+xFkHo7sh+SzsyvJis7G5m7es6DwqHmfLcJIzal9FmdDBgdM+uWx5cGSRFo3emTcWvnZ5h7dTV1z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759828185; c=relaxed/simple; bh=1yfqm08lPzP84DqSlgtHVuQqNXB/UVXPe0ZvuASpvXY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pya7/7RNjVHmczZFChswyumHmjHunBSRzYSnvcaG35uY/brn1nHpeb60TJnGvyP4xD1fomN3UHuBETNcwhyhwMlowb6B+0wo6ZXl0dz3zPBdOZD6j5TxlACyKeRPt/AAvU6BxRyrCAuCsaoPvKN3bOr0WnQu0+Vj7VxSmy3O3IU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HPetP9p3; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HPetP9p3" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7bc626c5461so1988954a34.3 for ; Tue, 07 Oct 2025 02:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759828182; x=1760432982; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k5Gn50jfOxZiiSgXxR/gre/tjvhockNBFkRAG2DI30U=; b=HPetP9p3Rcyr+4Rerd3eUcPywk0U+/cpJZQguNYVaEhi7UH/pho9dG27K39tRbutjz a0msZ7YzoHLi9+3ghjpUAlBzlRx6+1sWCr2Z4KhFtLX4tG9M982U9qdv5bud/9NTZUGc 351joCL0Y7gZnCKbdSccb7ySAXAV8ceGTLNjziRVI0+G/nNVs8vYNsF24q0n2UgxGcOZ nbfZD2kF4gB6fqOPhtOSkqLJOStWZQS6yLLezTzyhXtrNt9fEk7uQTEvnwX7yWUWGrAm MGXAG3D/dEvSMMgJst7VT5SiBd9mDvh+2KcQ9W2vfZG3031A+yRAa6o6hOWlwfecydVF OLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759828182; x=1760432982; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k5Gn50jfOxZiiSgXxR/gre/tjvhockNBFkRAG2DI30U=; b=fOEco7Wnw4rHfNkofrsuftKN/M2nIUWXZK6fRwRjxQQJGvjMtsH13I8O+wVs+FP4K0 mzAWUy2AvnKj6xQjK/oWRdK4kjh8SElgwWDULHI7Ldzi2RPppgVxpyFNtck1eP50h9O/ tpRkzSRIHP0ZnIyASrGZzMVE41CiW92AOiL4hnKt2lI/wZud1MLnEjncoRqWPVpmmeY5 /md6/j2nWZ9/Na5LAj9vPjldachq5/5MEs+KBufSubsjr4xrk7Bm0POOgHEbIeVky/oz 4lFyFf8DCwk7XO4soqM2T2iq+3l6rA5EeKT+r1odeZBoJGUmopqdC6uMnprIfoQ6DE4i HGRw== X-Forwarded-Encrypted: i=1; AJvYcCX4ol7Mm1qmXaHGvEtL79lUxlj60OqMI9oSEFKQrzDGneMnsQj4A7kAJ5gPSlg2BEITHaqWKVQRxfKl@vger.kernel.org X-Gm-Message-State: AOJu0Yy5ZqLN1dpLu4V1MDPyo9kzQjx/bsJCeIGUtN74OY4eBzd7vh6u hCDgxZqCQTnobaYiTaCW/Yg4dvipDxXRZ+2Io9b4cKmcsdGLNqnsmJGTmcueVgHjRNp69tPaTxZ 5LJzpYzzAiwKeJY0+a/j6iZBQCSkIlgkU2fJOgpXdOQ== X-Gm-Gg: ASbGncu0tJO4kpbcqfkEFcX/noaazyKF/hLE5BmXGdH5lYVYcovhT1/B5YaRj+6Dosi iemjUD/2VBCQIm4vt8qfDqIv4IVC8gddwgHxbThmK7gNz4ec1etYlQscJdvCKCAQ1p1AtyYv92n sOWJFCGsAfnPLCPOGd7t0FFwrhccI5exHKKsbxGT0fPldJccWIUSsFF3seuWgdJXc/orVL+lfrX D7vYeBCXn1GPjgVQ+fvOPXKpYy1iozvPB0LTg== X-Google-Smtp-Source: AGHT+IFtOrLlwJK0/TEgM+f2IS4t9o4gV7fAIVv15sfMLe5yqLK9nGKna5+x4B1VTMirLjZ+oFvqM3iKI6ns6JfL4hs= X-Received: by 2002:a05:6808:3096:b0:438:2907:2ead with SMTP id 5614622812f47-43fc18a2091mr6585032b6e.50.1759828182026; Tue, 07 Oct 2025 02:09:42 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251006232125.1833979-1-royluo@google.com> <20251006232125.1833979-3-royluo@google.com> <8ca61364-df47-41f2-b0d1-f2a8a74ec728@kernel.org> In-Reply-To: <8ca61364-df47-41f2-b0d1-f2a8a74ec728@kernel.org> From: Peter Griffin Date: Tue, 7 Oct 2025 10:09:31 +0100 X-Gm-Features: AS18NWD7ktu7qt-H0DxecJcoZK61ZH3ap7EbdS2ccz0Z-j7ffn7elGuijfKqbpQ Message-ID: Subject: Re: [PATCH v1 2/4] dt-bindings: usb: dwc3: Add Google SoC DWC3 USB To: Krzysztof Kozlowski Cc: Roy Luo , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Thinh Nguyen , Philipp Zabel , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Joy Chakraborty , Naveen Kumar , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Krzysztof & Roy, Firstly thanks Roy for your patches, it's great to see more Tensor support being posted upstream! On Tue, 7 Oct 2025 at 01:44, Krzysztof Kozlowski wrote: > > On 07/10/2025 08:21, Roy Luo wrote: > > Document the DWC3 USB bindings for Google Tensor SoCs. > > > > Signed-off-by: Roy Luo > > --- > > .../bindings/usb/google,snps-dwc3.yaml | 144 ++++++++++++++++++ > > 1 file changed, 144 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/google,snps-dwc3.yaml > > > > diff --git a/Documentation/devicetree/bindings/usb/google,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/google,snps-dwc3.yaml > > new file mode 100644 > > index 000000000000..3e8bcc0c2cef > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/google,snps-dwc3.yaml > > @@ -0,0 +1,144 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright (c) 2025, Google LLC > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/google,snps-dwc3.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google DWC3 USB SoC Controller > > + > > +maintainers: > > + - Roy Luo > > + > > +description: > > + Describes the Google DWC3 USB block, based on Synopsys DWC3 IP. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - google,lga-dwc3 > > + - const: google,snps-dwc3 > > > There is no such soc as snps, so you grossly misuse other company name > as name of SoC. Neither lga. Otherwise please point me to the top-level > bindings describing that SoC. > > You need to better describe the hardware here - why this is something > completely different than GS which. Or switch to existing bindings and > existing drivers. Did you align this with Peter Griffin? I think (from what I've seen at least) this is the first submission for drivers in the Tensor G5 SoC used in Pixel 10 devices (which as I understand it isn't based on any Samsung IP). Hence the new drivers, bindings etc. However the issue is that none of the other base SoC drivers on which this driver depends currently exist upstream (like clocks, reset driver, power domains, pinctrl etc). So it's very hard to reason about the correctness or otherwise of this submission. It is also likely that when those drivers are upstreamed things could change in the review process, to how it looks today in the downstream kernel. So in summary I think to progress with this we need to get the base Tensor G5 SoC drivers merged first (e.g. boot to console with pinctrl, basic clock support, reset driver etc). Then we can start adding in some of the other peripherals like i2c/spi/usb etc and build up the mainline support from there. Thanks, Peter.