devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gene Chen <gene.chen.richtek@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	robh+dt@kernel.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Gene Chen <gene_chen@richtek.com>
Subject: Re: [PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator
Date: Mon, 24 Aug 2020 18:23:19 +0800	[thread overview]
Message-ID: <CAE+NS34WuWnT7zvsHhaciWVLT2y0wpwt0wXAp3UmjEuJ2its6A@mail.gmail.com> (raw)
In-Reply-To: <20200820114524.GC5854@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2020年8月20日 週四 下午7:45寫道:
>
> On Thu, Aug 20, 2020 at 03:53:41PM +0800, Gene Chen wrote:
>
> > +     mrd->regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > +     if (!mrd->regmap) {
> > +             dev_err(&pdev->dev, "Failed to get parent regmap\n");
> > +             return -ENODEV;
> > +     }
>
> > +static const struct of_device_id __maybe_unused mt6360_regulator_of_id[] = {
> > +     { .compatible = "mediatek,mt6360-regulator", },
> > +     {},
> > +};
> > +MODULE_DEVICE_TABLE(of, mt6360_regulator_of_id);
>
> This device only exists in the context of a single parent device, there
> should be no need for a compatible string here - this is just a detail
> of how Linux does things.  The MFD should just instntiate the platform
> device.

Trying to autoload module without of_id_table will cause run-time error:
ueventd: LoadWithAliases was unable to load
of:NregulatorT(null)Cmediatek,mt6360-regulator

https://lore.kernel.org/patchwork/patch/726691/
According to this patch, autoload can't load module which doesn't
include add id_table or of_id_table in module.alias
So I need keep of_if_table for auto load success

  reply	other threads:[~2020-08-24 10:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  7:53 [PATCH v3 0/2] regulator: mt6360: Add support for MT6360 regulator Gene Chen
2020-08-20  7:53 ` [PATCH v3 1/2] " Gene Chen
2020-08-20 11:45   ` Mark Brown
2020-08-24 10:23     ` Gene Chen [this message]
2020-08-24 11:04       ` Mark Brown
2020-08-25  9:13         ` Gene Chen
2020-08-25  9:26           ` Mark Brown
2020-08-20  7:53 ` [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation Gene Chen
2020-08-20 11:30   ` Mark Brown
2020-08-24  7:21     ` Gene Chen
2020-08-24 19:48       ` Mark Brown
2020-08-25  9:21         ` Gene Chen
2020-08-25  9:34           ` Mark Brown
2020-08-25 10:01             ` Gene Chen
2020-08-25 10:08               ` Mark Brown
2020-08-25 11:07                 ` Gene Chen
2020-08-26 12:55 ` [PATCH v3 0/2] regulator: mt6360: Add support for MT6360 regulator Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE+NS34WuWnT7zvsHhaciWVLT2y0wpwt0wXAp3UmjEuJ2its6A@mail.gmail.com \
    --to=gene.chen.richtek@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gene_chen@richtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).