From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF64C433FE for ; Mon, 13 Sep 2021 19:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D91761108 for ; Mon, 13 Sep 2021 19:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242075AbhIMTwg (ORCPT ); Mon, 13 Sep 2021 15:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240911AbhIMTwg (ORCPT ); Mon, 13 Sep 2021 15:52:36 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A614C061760 for ; Mon, 13 Sep 2021 12:51:20 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so14961330otq.7 for ; Mon, 13 Sep 2021 12:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to; bh=7y5Kp92MxlMIM/1uVfkHDfbY3sPUaGnffDNVZpUsrD8=; b=Zodc0o0JSl2wPuA2Y12NHWaoDY6QABXb137QrHTXqY11BK/0mIsSmDtqRM4Zm7UmRG NDS8f4Q5f7Sc3gTutg/hC+SubqhccAhKu6HsGcUna0XluSh0IyQOT9ytmBIL+CvFukJv wuSKCsLqUBP1ML9pxEFAKZPdUExJgd3OvfLFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to; bh=7y5Kp92MxlMIM/1uVfkHDfbY3sPUaGnffDNVZpUsrD8=; b=UeIUtLHy+/PX3LrkPX8iWv4B9hQuMLae6BbncU3ZyyTCogSoe6iII0we1Pb2qhEWFB +UhRyTcASXLHO0xPzAAQaVZ/D/UHF0T+qY6H/7i5t20gpZk0OWAAsPhRY+D6U8wbVlBv eK5a8gs1Tbvz1hnbGdKaiD/S2uF5vM4k/sF6mSV4mDd9x782Qt9PV5vsRT8DlysaQ/eN KKfjdvE4K5LDuFEJPTPcmV7y/5FFAGxFIdCpc39zUdWT7vpzFXqKEArbfpTOETgNq0Po EX1CPQMPR65lUefQ5Jc90RQEiaHLoQoiv8z/h0A0l6UHL6gj9Yyn2mk02Mf/1s6nw3f1 u7eQ== X-Gm-Message-State: AOAM532/ZfqnlevzxIOYNsbXLkjSnrZOZ7EN1L4HWr28U4tJonoWDlFv NpfJbQx3ZzJr90SXK3N/aR/z5N/sXok+sxWQTz/DKQ== X-Google-Smtp-Source: ABdhPJy8cOper52GzW4GbJAI4BPyVQYu27nMzrhL6XZsTO4p+Lv1yS1UiO9YJYTrQ5nwZM9IcOtzIoPX1a3xvmpfAnI= X-Received: by 2002:a05:6830:18c7:: with SMTP id v7mr11189838ote.126.1631562679479; Mon, 13 Sep 2021 12:51:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 13 Sep 2021 12:51:19 -0700 MIME-Version: 1.0 In-Reply-To: <1631539062-28577-2-git-send-email-srivasam@codeaurora.org> References: <1631539062-28577-1-git-send-email-srivasam@codeaurora.org> <1631539062-28577-2-git-send-email-srivasam@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 13 Sep 2021 12:51:19 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings To: Srinivasa Rao Mandadapu , agross@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, bjorn.andersson@linaro.org, broonie@kernel.org, devicetree@vger.kernel.org, judyhsiao@chromium.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, perex@perex.cz, plai@codeaurora.org, robh+dt@kernel.org, rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org, tiwai@suse.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Srinivasa Rao Mandadapu (2021-09-13 06:17:41) > diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > new file mode 100644 > index 0000000..e0d705f > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > @@ -0,0 +1,169 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/google,sc7280-herobrine.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google SC7280-Herobrine ASoC sound card driver > + > +maintainers: > + - Srinivasa Rao Mandadapu > + - Judy Hsiao > + > +description: > + This binding describes the SC7280 sound card which uses LPASS for audio. > + > +properties: > + compatible: > + enum: > + - google,sc7280-herobrine > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^dai-link@[0-9a-f]$": > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + reg: > + maxItems: 1 > + description: dai link address. > + > + cpu: > + description: Holds subnode which indicates cpu dai. > + type: object > + properties: > + sound-dai: true Shouldn't sound-dai be required? > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + properties: > + sound-dai: true Shouldn't sound-dai be required? I don't know but maybe also additional properties is false for this node too? > + > + required: > + - link-name > + - cpu > + - codec Should 'reg' be required? > + > + additionalProperties: false