From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06172C433EF for ; Sat, 19 Feb 2022 01:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240846AbiBSBu5 (ORCPT ); Fri, 18 Feb 2022 20:50:57 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbiBSBu4 (ORCPT ); Fri, 18 Feb 2022 20:50:56 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09A0725B6D2 for ; Fri, 18 Feb 2022 17:50:39 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id z7so1979917oid.4 for ; Fri, 18 Feb 2022 17:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=iQdqk3TnJErEbPNDiC4Mb5t6O95gNpK1dN2mo5Ib0wY=; b=WRYdTLyVGDcaLis/GHRSHAOoFFVnVeZi3whJAi6JIsiF9Ko/gL3HPr/3N5fKfwcFSk jmQGmDzHh7TilTCt6zObkTMDouUgSO6UM+9U7rZfhtaFXISd43V8VZK9+BB7iUBUDl7G Nvj/15HiMEY9jYoKp+0yF/A3yNJVVjGpusP6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=iQdqk3TnJErEbPNDiC4Mb5t6O95gNpK1dN2mo5Ib0wY=; b=iXnl5DdbGr1KZlIUrD3tHTmrOvVmjHgzeUvf2zeOKG0Rk60hnrWYoouc0b9BtUz34k xGJtmLatDP6Oulco4sy8nAAz/xIt9ATfRmEDpupD0ghwN2X+QlOts1pDEdrNRrfHk6p/ IP7dN0MhG+VYF7SeIhg9L/jRSnY+DHapUnzEE1tOl3txPWM+Ro2hFC70lkKjBp0lCOTo 6nyUziCRPh2tD0QJQA6mekx6ppoYmOGQkDAvaNSxMWWrcniasNQptwbijs8s+8dTZI32 fFEvogZMWJqwXPtsx+TchZij4Dn0ZmwcqipoHSEVNgh4mt5n23kndqrnR4Ue27WXlzM7 TQ9Q== X-Gm-Message-State: AOAM5329VpOPXMDWT1MlloxmLuMVIxh0RFZVOxFPViQAPOW5QCqVSuRZ MqogV+8zfuFGSHe/V5d9O1560QflMGs8j5aWE1z8vg== X-Google-Smtp-Source: ABdhPJyBjVxmZ85zfetySH4t0ngAoSWvUFWgLABLiNdUWsdfWBzxvDturAoF83YxAK+5IcA1VhmUmMHth+830OCMGmY= X-Received: by 2002:a05:6808:f88:b0:2d4:c8c2:b898 with SMTP id o8-20020a0568080f8800b002d4c8c2b898mr541902oiw.112.1645235438430; Fri, 18 Feb 2022 17:50:38 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 18 Feb 2022 17:50:38 -0800 MIME-Version: 1.0 In-Reply-To: <1645182064-15843-4-git-send-email-quic_c_skakit@quicinc.com> References: <1645182064-15843-1-git-send-email-quic_c_skakit@quicinc.com> <1645182064-15843-4-git-send-email-quic_c_skakit@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 18 Feb 2022 17:50:38 -0800 Message-ID: Subject: Re: [PATCH V7 3/5] regulator: Add a regulator driver for the PM8008 PMIC To: Bjorn Andersson , Rob Herring , Satya Priya Cc: Lee Jones , Liam Girdwood , Mark Brown , Das Srinagesh , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_jprakash@quicinc.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Satya Priya (2022-02-18 03:01:01) > Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC > containing 7 LDO regulators. Add a PM8008 regulator driver to > support PMIC regulator management via the regulator framework. > > Signed-off-by: Satya Priya > diff --git a/drivers/regulator/qcom-pm8008-regulator.c b/drivers/regulator/qcom-pm8008-regulator.c > new file mode 100644 > index 0000000..1c52864 > --- /dev/null > +++ b/drivers/regulator/qcom-pm8008-regulator.c > @@ -0,0 +1,205 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define VSET_STEP_MV 8 > +#define VSET_STEP_UV (VSET_STEP_MV * 1000) > + > +#define LDO_ENABLE_REG(base) ((base) + 0x46) > +#define ENABLE_BIT BIT(7) This is SPMI_COMMON_REG_ENABLE and SPMI_COMMON_ENABLE_MASK > + > +#define LDO_VSET_LB_REG(base) ((base) + 0x40) > + > +#define LDO_STEPPER_CTL_REG(base) ((base) + 0x3b) > +#define DEFAULT_VOLTAGE_STEPPER_RATE 38400 > +#define STEP_RATE_MASK GENMASK(1, 0) > + > +struct regulator_data { Please use a name like spmi_regulator_data :) Or pm8008_regulator_data? Something that isn't so generic. It seems similar to qcom_spmi-regulator.c so is there some reason we can't shove this into there? Less code for things that aren't relevant I guess? > + const char *name; > + const char *supply_name; > + u16 base; > + int min_uv; > + int max_uv; > + int min_dropout_uv; > + const struct linear_range *voltage_range;