From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE7E1C6880 for ; Tue, 20 Aug 2024 17:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174691; cv=none; b=Fv78iJinOTDaUjxQh5wt+cyN3WI1x20krZ/GBj02yGwSbqMTqDeR0WGn5KuL5s3WH7Ef2UhBa/sn9rNx/T1MMccdShZ0eiLqIBCxECE3mDItA0HwlMLFT5FpNPNmxdWmOvGE0pLcK9PjjyRWdjFuD4RXpV8ONuQ1OfLrZHxEizo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174691; c=relaxed/simple; bh=5jI+2p5tO5nOwZs3G8vuy7obODZwjARI/RidWxG+P/0=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=XNHEz5FVnO7ugPwmVQvEQjV1DwpOE9LnijWsLMQxQdv6K+R8Tp68hRoCdjtlxOW60TcaMmFRxnr4BCXNEJUbTpYEXPKhmILArt/8mt35tICsQ40o/xyQgm4XQS8+zpiQ0lsoMzcknj5Eckc3yhEVviZlXtJalENoceBJOA32xKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=k7UAdq/0; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="k7UAdq/0" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7a3375015f8so398267685a.1 for ; Tue, 20 Aug 2024 10:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724174688; x=1724779488; darn=vger.kernel.org; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:from:to:cc:subject:date:message-id :reply-to; bh=Kivk6OVMCb2Ic/WQYTSiSJ7knOT9aLnIRhStn7/b1EY=; b=k7UAdq/0AOXuatYlkTYVPglCWbt1B8OSBoplCE6KJyj/wrrE68kTwxZFdIkgfVlZmM kS19G2FZpoLKMGfKKGkgpGV6shDKpcYOThTTZrugD0BVIHdjeRD1zgKDsZ1oWpRvAWgD RQYyvP7n89b5kWxcbU5iZh7a12vX9nZlMefDw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724174688; x=1724779488; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kivk6OVMCb2Ic/WQYTSiSJ7knOT9aLnIRhStn7/b1EY=; b=OS3MfhBwDvkH3TjvlMHRC2b/gTa/5TsckmpG6jK5SLZ+IjKyF+qKGlwHGTaOfL3n+m F2p7snxbCqlmhI2nSTpYa7oji3Npqq6Gpu3PXBInf5RmRiZtAf0IKUxz04xJfXPmzhOb ZxPEzOi6LxIc4JS4U83TyRCCm28YIQ1xmc4tqrzxyjajJYiDtDWNJhf6bp5gI9K5eYPb vws5Rd46s7ATbyjBBZzTyyzx5NHRsQdjoR6EqnVb8o0hKPbPnaZq9nOs7mSQuE4KavNC Kaz2Tjn38UCVLykvmtiohqCrqsS7jwTviubpQsm01LVVAzwX/nWARQPdYepCU0IBPO4I KhYg== X-Forwarded-Encrypted: i=1; AJvYcCUlUDleAbvAUByDzU9NIIzHLsjYWBp/pp/cyqJBxC1oCpmGvGxsG9AEQ541+rp/KTNiIME+vOUG3fGg9CebX2VNPOZFUFEogVuQpQ== X-Gm-Message-State: AOJu0YxRIzOCHT19CA/86+OvC/92L8dOoj8gbEIpf4WoEoh6bbRMx25C uWzrtDmsOm5mkn2PwNrAxLINHYR4wscnkpqNls2MDMbE5cApLRwPHj0Ou7iuRdcTecPEa37xG23 9G6exfEcTK2dvq/zdkzHct2YL8o5BKCTCfKRr X-Google-Smtp-Source: AGHT+IFPnbaIpKnJbRF0KVl+CpiSvIEMrBAyBLBBnH5HxEKdAtvNgsfFmldfo1C+7jIx6Rn++JaBGcZOF4ZPpQUlOKY= X-Received: by 2002:a05:620a:319c:b0:7a3:6dd9:efbb with SMTP id af79cd13be357-7a50695402emr1528659285a.33.1724174688344; Tue, 20 Aug 2024 10:24:48 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Aug 2024 10:24:47 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: References: <20240819223834.2049862-1-swboyd@chromium.org> <20240819223834.2049862-3-swboyd@chromium.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 20 Aug 2024 10:24:47 -0700 Message-ID: Subject: Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check To: Andy Shevchenko Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Douglas Anderson , Pin-yen Lin , Andrzej Hajda , Benson Leung , Conor Dooley , Daniel Vetter , David Airlie , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Guenter Roeck , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lee Jones , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Prashant Malani , Robert Foss , Rob Herring , Thomas Zimmermann , Tzung-Bi Shih , Alexandre Belloni , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , Ivan Orlov , linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org, Mika Westerberg , "Rafael J . Wysocki" , Sakari Ailus , Vinod Koul Content-Type: text/plain; charset="UTF-8" Quoting Andy Shevchenko (2024-08-20 10:17:46) > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: > > > > + /* > > > > + * Ensure this bridge is aware that the next bridge wants to > > > > + * reassign lanes. > > > > + */ > > > > + for (i = 0; i < num_input_lanes; i++) > > > > + if (i != input_lanes[i].logical && !num_output_lanes) > > > > + return -ENOTSUPP; > > > > > > Besides missing {} this code is internal to the Linux kernel. Is it okay? > > > > ENOTSUPP is used by select_bus_fmt_recursive() so I simply followed that > > style. > > Okay, just be aware of that side effect of that code, also checkpatch may > complain (however it might be false positive). Yes checkpatch complained but didn't enlighten me. Please tell me the side effect as I'm unaware!