From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958BEC433EF for ; Tue, 10 May 2022 17:40:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348365AbiEJRov (ORCPT ); Tue, 10 May 2022 13:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348362AbiEJRot (ORCPT ); Tue, 10 May 2022 13:44:49 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5C511E3F1 for ; Tue, 10 May 2022 10:40:49 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id w130so7454312oig.0 for ; Tue, 10 May 2022 10:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=UKufSQs9qr2bj9JxpR70M2MLmSNQQ67hZiGFvmJhYoc=; b=mdY/If8uRLEfI44R6YGWNOJxV4pcVZkV2cqgKl6mPn2qSRu9ZEv1lEWDIFC2daiykt 2e1RiT9qD3sYV5V/WfZx0zxgjzmxv1dsDsRhjJ9fNdW9WfpT/PoLmKh1gugpSSvyB9OS r5ivIcCI5Z4QdKRZvhVb8GLWcVU4lgDzVyo9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=UKufSQs9qr2bj9JxpR70M2MLmSNQQ67hZiGFvmJhYoc=; b=5bLvK7DYqOJ0M9UOw6GHLH5630+8mh2+LFV4eAwODoir5UOH37NEQ4UlAqsRn9Jo2+ Ird4uoCRZLF8fFD5D6At9V4b88tznWmtIYnuijXgm65HGbZ8pLhhMerhkb1wv0AfokmU bSe5s2umgZJSlLewnAWigiltf8dJ4EyiibfgQuFqXcz9bw4OBfEbJwtMarh0C16UotbB ZgoAho7x2FdOsI5C5B+OpCDzS+Pqkw78ui/v5BE9aJdOVWA7Yg7rBBekavdS86YykxcR Tpb0pCBvgVVYuGHnPzA7AsD+vQ42Bo2XriH8LS9/qVutxtkNetPX7agedoaPibdzfKg6 gCbA== X-Gm-Message-State: AOAM532UFoYEwPn5n+dVqreN8qo+lX0t/vJavcuUCkz2fYtxKM3Xd1FQ 11iCdWXrIiOIQGErFHthgV2lGj2sBOmitVw6I83W+w== X-Google-Smtp-Source: ABdhPJz95HjcXUXoUbA/7guupIrd/nNtcSppXPf36HaH/0UjgRjU1DiKnHjuUteekXQ3UkimNseRwGrch2RzwVkttFo= X-Received: by 2002:a05:6808:14c2:b0:326:c129:d308 with SMTP id f2-20020a05680814c200b00326c129d308mr576354oiw.193.1652204449230; Tue, 10 May 2022 10:40:49 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 10 May 2022 10:40:48 -0700 MIME-Version: 1.0 In-Reply-To: <20220505104024.v4.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid> References: <20220505104024.v4.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 10 May 2022 10:40:48 -0700 Message-ID: Subject: Re: [PATCH v4 1/5] arm64: dts: qcom: sc7180: Add wormdingler dts files To: "Joseph S. Barrera III" , LKML Cc: Douglas Anderson , Alexandru M Stan , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Joseph S. Barrera III (2022-05-05 10:41:12) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi > new file mode 100644 > index 000000000000..e947e01d0b3b > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi > @@ -0,0 +1,417 @@ [...] > + > +/* PINCTRL - board-specific pinctrl */ > + > +&tlmm { > + gpio-line-names = "HUB_RST_L", [...] > + > + vdd_reset_1800: vdd-reset-1800 { > + pinmux { > + pins = "gpio87"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio87"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > + > + avdd_lcd_en: avdd-lcd-en { > + pinmux { > + pins = "gpio88"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio88"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > + > + avee_lcd_en: avee-lcd_en { avee-lcd-en No underscores in node names please. > + pinmux { > + pins = "gpio21"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio21"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; Are these supposed to be sorted by node name? Or gpio number? Please do one of those. > + > + mipi_1800_en: mipi-1800-en { > + pinmux { > + pins = "gpio86"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio86"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > +};